🐛 Add published_at to post model fixtures
#8573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinansfield
requested changes
Jun 13, 2017
| // are different, otherwise `prev_post` and `next_post` helpers won't workd with | ||
| // them. | ||
| if (model.name === 'Post') { | ||
| _.forEach(model.entries, function (post, key) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
closes TryGhost#8562 Before we create our model fixtures, we assign a `published_at` property with a difference of 1 second for each blog post, so the `prev_post` and `next_psot` helper work correctly. This fixed also an issue, where the order of the fixtures wasn't correct.
aileen
force-pushed
the
1.0.0-dev/fix-post-fixtures-published-date
branch
from
b2c6c19
to
c729981
Compare
|
If the code seems ok, this is ready for merging! I tested it with sqlite and MySQL. |
kevinansfield
approved these changes
Jun 13, 2017
kirrg001
reviewed
Jun 13, 2017
| // them. | ||
| if (model.name === 'Post') { | ||
| _.forEach(model.entries, function (post, index) { | ||
| post.published_at = moment().add(index, 'seconds'); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
aileen
added a commit
to aileen/Ghost
that referenced
this pull request
Sep 13, 2017
no issue follow-up from TryGhost#8573 Move the hack that creates `published_at` values from the migration fn to our fixture util.
kirrg001
pushed a commit
that referenced
this pull request
Sep 19, 2017
no issue - follow-up from #8573 - bove the hack that creates published_at values from the migration fn to our fixture util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8562
Before we create our model fixtures, we assign a
published_atproperty with a difference of 1 second for each blog post, so theprev_postandnext_posthelper work correctly. This fixed also an issue, where the order of the fixtures wasn't correct.