🐛 Fixed private blogging leaking post information

[kirrg001]

closes #8990

• a condition in the private blogging app redirected rss && sitemap to 404, which can possibly leak content
• remove this condition and ensure we always redirect to /private
• robots.txt can stay, as it doesn't expose any post data

@ErisDS
Please see.
Why was this logic added in the first place? I was unable to find any reason.

[ErisDS]

@kirrg001 as per #8990 (comment), I agree that this logic can be changed to require the cookie instead of 404 and that that is a better approach.

Ideally, I think we should be looking to disable the whole sitemap feature for private blogs, so we don't end up doing all of the work that goes with it. However that is an optimisation, not high priority.

RSS feeds are slightly different - we need to provide a different, better way for people to access RSS feeds when the blog is in "private" mode, or when a blog requires memberships. E.g. the RSS feed lives on an unguessable route.

[kirrg001]

Ideally, I think we should be looking to disable the whole sitemap feature for private blogs, so we don't end up doing all of the work that goes with it. However that is an optimisation, not high priority.

Yeah, because it's only used for SEO optimisation. But agree, future improvement.

RSS feeds are slightly different - we need to provide a different, better way for people to access RSS feeds when the blog is in "private" mode, or when a blog requires memberships. E.g. the RSS feed lives on an unguessable route.

We've rendered a 404 page before, so i guess this is a future improvement as well? As soon as we have clear use cases (e.g. blogs which are private, but have memberships, the members should be able to access rss or if a blog has memberships, you are not able to make your blog private or ....), we can improve this.