Misc cleanup & consistency amends #9002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no issue - makes it easier to search and inspect the various usages
no issue - Simplifies this util to make it easier to see what it does
- add some consistency to the calls to res.render - making it clearer what code is the same to aid in refactoring
- This was used during prototyping to differ between different ORMS!!! 😱 - Let's call it models everywhere now...
- we're no longer using alignment in vars
- always refer to local utils as apiUtils - logical grouping of requires - dependencies, utils, "lib common" etc - use xAPI to refer to API endpoints, e.g. mailAPI, settingsAPI for clarity
kirrg001
reviewed
Sep 12, 2017
core/server/api/clients.js
Outdated
| @@ -2,7 +2,7 @@ | |||
| // RESTful API for the Client resource | |||
| var Promise = require('bluebird'), | |||
| _ = require('lodash'), | |||
| dataProvider = require('../models'), | |||
| models = require('../models'), | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a collection of tiny changes to the code base - mostly around consistency of naming things / ordering things.
These things absolutely do not matter normally. When searching & comparing bits of the codebase to try to figure out how to abstract out certain concepts, which I'm doing a lot of at the moment, absolute consistency makes things clearer.
Therefore these changes just make it easier for me to do more intensive changes on top of the codebase.
There should be zero behavioural changes in here.