Eslint

[ErisDS]

Had a go at switching to eslint.

Somewhere in 417d690 I think I broke something 😱 can anyone spot what?

What I did was:

• run eslint --init and choose the "inspect code" option.
• I did this for all server files, and then all test files separately
• then I fixed the handful of issues
• then I changed a few style rules that we have always had, only eslint is way better at this stuff
• I went through loads of files using the Ctrl + Alt + L shortcut to fix indent and other problems
• finally, I disabled a lot of style rules for the tests cos seriously this isn't important

[ErisDS]

OK so this is green now. I propose:

• Merge now as-is.
• If there are any rules that really annoy you, turn them off when you find them.
• If there is anything that is not being picked up, add to the rules when you find them.

There are some rules that I already turned off that we might want to look at again:

• no-useless-escape
• vars-on-top
• max-len
• no-buffer-constructor
• array-callback-return

It takes quite a lot to really research a rule, apply it, update all the code etc. Doing one rule at a time will be a lot easier than trying to do all of them in one go was 😁

P.S. ESLint is ~40seconds faster, reducing lint time on travis from ~2.20 to ~1:40