-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eslint #9197
Eslint #9197
Conversation
core/server/utils/index.js
Outdated
@@ -21,6 +21,7 @@ utils = { | |||
/** | |||
* Timespans in seconds and milliseconds for better readability | |||
*/ | |||
/* eslint-disable key-spacing | |||
ONE_HOUR_S: 3600, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
OK so this is green now. I propose:
There are some rules that I already turned off that we might want to look at again:
It takes quite a lot to really research a rule, apply it, update all the code etc. Doing one rule at a time will be a lot easier than trying to do all of them in one go was 😁 P.S. ESLint is ~40seconds faster, reducing lint time on travis from ~2.20 to ~1:40 |
Had a go at switching to eslint.
Somewhere in 417d690 I think I broke something 😱 can anyone spot what?
What I did was:
eslint --init
and choose the "inspect code" option.