Removed the less than 1 min reading time clause #9573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #9569 - Removed the less than 1 minute reading time clause, effectively making 1 min the minimum reading time - Removed the 'seconds' option for i18n strings, which contained the less than one minute display string - Kept the other i18n string options the same - Amended and improved tests for new functionality
core/server/helpers/reading_time.js
Outdated
| @@ -48,11 +47,9 @@ module.exports = function reading_time(options) {// eslint-disable-line camelcas | |||
| readingTimeSeconds += Math.max(i, 3); | |||
| } | |||
|
|
|||
| readingTimeMinutes = Math.round(readingTimeSeconds / 60); | |||
| readingTimeMinutes = Math.max(Math.round(readingTimeSeconds / 60), 1); | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
aileen
approved these changes
Apr 18, 2018
This was referenced Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9569