Update post-card.hbs #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading time helper compatibility with i18n translation. -
juan-g
requested changes
Apr 23, 2018
partials/post-card.hbs
Outdated
| @@ -35,7 +35,7 @@ | |||
| {{/foreach}} | |||
| </ul> | |||
|
|
|||
| <span class="reading-time">{{reading_time}}</span> | |||
| <span class="reading-time">{{reading_time seconds=(t "< 1 min read") minute=(t "1 min read") minutes=(t "% min read")}}</span> | |||
There was a problem hiding this comment.
Thanks. Given that, some days ago, they removed the "< 1 min read" option (see Ghost issue #9573), the seconds=(t "< 1 min read") part should be removed from this pull request before merging, remaining:
{{reading_time minute=(t "1 min read") minutes=(t "% min read")}}
Thanks again.
.Some days ago, they removed the "< 1 min read" option, so this line should be removed (see Ghost issue #9573).
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading time helper compatibility with i18n translation.