✨ Added advanced filtering to dynamic routing #9757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#9601 - Upgraded NQL to 0.1.0 - The new version of NQL supports aliases - This allows us to support advanced filtering like tag:[a,b] - In dynamic routing, we use mingo via NQL which has a slightly different feature set to GQL in the API: - AND NOT, OR and other advanced logic combos DO work on joined tables - Counts are not yet supported
|
Cool, will test and merge asap 👍 |
kirrg001
force-pushed
the
2.0
branch
7 times, most recently
from
e25db60
to
372dd36
Compare
kirrg001
pushed a commit
that referenced
this pull request
Aug 3, 2018
refs #9601, refs #9742 - Upgraded NQL to 0.1.0 - The new version of NQL supports aliases e.g. `tag: tags.slug`, which makes it possible to define `filter=tag:support` - Furthermore, this allows us to support advanced filtering like tag:[a,b] - In dynamic routing, we use mingo via NQL which has a slightly different feature set to GQL in the API: - AND NOT, OR and other advanced logic combos DO work on joined tables - Counts are not yet supported - The Dynamic Routing beta docs should describe that API filtering and Dynamic Routing filtering is different
kirrg001
pushed a commit
that referenced
this pull request
Aug 9, 2018
refs #9601, refs #9742 - Upgraded NQL to 0.1.0 - The new version of NQL supports aliases e.g. `tag: tags.slug`, which makes it possible to define `filter=tag:support` - Furthermore, this allows us to support advanced filtering like tag:[a,b] - In dynamic routing, we use mingo via NQL which has a slightly different feature set to GQL in the API: - AND NOT, OR and other advanced logic combos DO work on joined tables - Counts are not yet supported - The Dynamic Routing beta docs should describe that API filtering and Dynamic Routing filtering is different
kirrg001
pushed a commit
that referenced
this pull request
Aug 10, 2018
refs #9601, refs #9742 - Upgraded NQL to 0.1.0 - The new version of NQL supports aliases e.g. `tag: tags.slug`, which makes it possible to define `filter=tag:support` - Furthermore, this allows us to support advanced filtering like tag:[a,b] - In dynamic routing, we use mingo via NQL which has a slightly different feature set to GQL in the API: - AND NOT, OR and other advanced logic combos DO work on joined tables - Counts are not yet supported - The Dynamic Routing beta docs should describe that API filtering and Dynamic Routing filtering is different
kirrg001
pushed a commit
that referenced
this pull request
Aug 10, 2018
refs #9601, refs #9742 - Upgraded NQL to 0.1.0 - The new version of NQL supports aliases e.g. `tag: tags.slug`, which makes it possible to define `filter=tag:support` - Furthermore, this allows us to support advanced filtering like tag:[a,b] - In dynamic routing, we use mingo via NQL which has a slightly different feature set to GQL in the API: - AND NOT, OR and other advanced logic combos DO work on joined tables - Counts are not yet supported - The Dynamic Routing beta docs should describe that API filtering and Dynamic Routing filtering is different
kirrg001
pushed a commit
that referenced
this pull request
Aug 11, 2018
refs #9601, refs #9742 - Upgraded NQL to 0.1.0 - The new version of NQL supports aliases e.g. `tag: tags.slug`, which makes it possible to define `filter=tag:support` - Furthermore, this allows us to support advanced filtering like tag:[a,b] - In dynamic routing, we use mingo via NQL which has a slightly different feature set to GQL in the API: - AND NOT, OR and other advanced logic combos DO work on joined tables - Counts are not yet supported - The Dynamic Routing beta docs should describe that API filtering and Dynamic Routing filtering is different
kirrg001
pushed a commit
that referenced
this pull request
Aug 12, 2018
refs #9601, refs #9742 - Upgraded NQL to 0.1.0 - The new version of NQL supports aliases e.g. `tag: tags.slug`, which makes it possible to define `filter=tag:support` - Furthermore, this allows us to support advanced filtering like tag:[a,b] - In dynamic routing, we use mingo via NQL which has a slightly different feature set to GQL in the API: - AND NOT, OR and other advanced logic combos DO work on joined tables - Counts are not yet supported - The Dynamic Routing beta docs should describe that API filtering and Dynamic Routing filtering is different
kirrg001
pushed a commit
that referenced
this pull request
Aug 13, 2018
refs #9601, refs #9742 - Upgraded NQL to 0.1.0 - The new version of NQL supports aliases e.g. `tag: tags.slug`, which makes it possible to define `filter=tag:support` - Furthermore, this allows us to support advanced filtering like tag:[a,b] - In dynamic routing, we use mingo via NQL which has a slightly different feature set to GQL in the API: - AND NOT, OR and other advanced logic combos DO work on joined tables - Counts are not yet supported - The Dynamic Routing beta docs should describe that API filtering and Dynamic Routing filtering is different
kirrg001
pushed a commit
that referenced
this pull request
Aug 14, 2018
refs #9601, refs #9742 - Upgraded NQL to 0.1.0 - The new version of NQL supports aliases e.g. `tag: tags.slug`, which makes it possible to define `filter=tag:support` - Furthermore, this allows us to support advanced filtering like tag:[a,b] - In dynamic routing, we use mingo via NQL which has a slightly different feature set to GQL in the API: - AND NOT, OR and other advanced logic combos DO work on joined tables - Counts are not yet supported - The Dynamic Routing beta docs should describe that API filtering and Dynamic Routing filtering is different
kirrg001
pushed a commit
that referenced
this pull request
Aug 16, 2018
refs #9601, refs #9742 - Upgraded NQL to 0.1.0 - The new version of NQL supports aliases e.g. `tag: tags.slug`, which makes it possible to define `filter=tag:support` - Furthermore, this allows us to support advanced filtering like tag:[a,b] - In dynamic routing, we use mingo via NQL which has a slightly different feature set to GQL in the API: - AND NOT, OR and other advanced logic combos DO work on joined tables - Counts are not yet supported - The Dynamic Routing beta docs should describe that API filtering and Dynamic Routing filtering is different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kirrg001 feel free to delete this and re-do it, or update any way you like. I just wanted to do a basic upgrade and test some functionality to show that it works now!
I'm not sure if there's anywhere I could add tests for the new behaviour.
This PR adds comprehensive filtering support to dynamic routing. Some advanced logical combos which don't work in GQL's knexify / or NQLs mongo-knex when filtering via SQL DO work with mingo when filtering JSON, e.g.
tag:a+tag:-bappears to work perfectly!NQL does not support any sort of count just yet though.
I think these are very advanced cases, and we can solve these discrepancies later, whilst still shipping code to support a very large range of use cases in the dynamic routing beta.
refs #9601