Refactored how we require shared middlewares from web/ #9893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
force-pushed
the
shared-package
branch
2 times, most recently
from
2840fa5
to
01af50b
Compare
kirrg001
changed the title
|
@rishabhgrg Ready for review. Tests should pass 🤞 |
NOOOO 😁 |
refs TryGhost#9866 - use package notation - get rid of x requires for middlewares - improved readability - do not refactor web/api/v0.1
kirrg001
force-pushed
the
shared-package
branch
from
01af50b
to
f291465
Compare
rishabhgrg
reviewed
Sep 21, 2018
core/server/web/site/app.js
Outdated
| const sitemapHandler = require('../../data/xml/sitemap/handler'); | ||
|
|
||
| // Route Service | ||
| const themeService = require('../../services/themes'); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
allouis
added a commit
that referenced
this pull request
Sep 25, 2018
* master: (25 commits) Version bump to 2.1.4 Updated Ghost-Admin to 2.1.4 Version bump to 2.1.4-beta.1 Updated Ghost-Admin to 2.1.4-beta.1 Updated private-sites to not redirect to full urls Bumped ghost-ignition to version 2.9.6 Upgrading Casper to 2.6.3 Refactored url utility to generate multiple API version URLs (#9897) Added new endpoint to upload square profile images with dimension validation (#9862) Removed change frequency and priority fields from sitemap generator (#9771) 🎨Added case insensitive support for redirects (#9755) Refactored direct usages of api controllers Normalised how we require models Refactored how we require shared middlewares from web/ (#9893) Removed duplicate 'id' for User permittedOptions Updated permittedOptions to correctly call super Updated base model to remove extraAllowedProperties Extended uncapitalise unit tests (#9891) Removed `res.isAdmin` from admin express app (#9889) Refactored `web/middleware` and `web/utils` to `web/shared` (#9892) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #9866