🐛 Fixed slash menu having fixed position when scrolling #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes TryGhost/Product#4112 - slash menu was using fixed positioning which meant scrolling whilst the menu was open caused a visual disconnect between the insertion point and the menu - switched positioning style to absolute - updated position calculation to work with relative top/bottom positioning - when using absolute positioning the "scroll into view when selected" behaviour for card menu items was causing random scrolling when the menu opened due to the render+reposition timing. Adjusted menu item component to only scroll into view when explicitly told to and updated the keyboard navigation in the slash menu to enable the scroll behaviour to avoid any initial-render scroll problems
kevinansfield
added a commit
to kevinansfield/Ghost
that referenced
this pull request
Nov 9, 2023
refs TryGhost#18752 refs TryGhost/Product#3897 refs TryGhost/Product#4112 refs TryGhost/Product#3802 refs TryGhost/Product#4104 refs TryGhost#18866 refs TryGhost#18753 refs TryGhost/Product#4116 refs TryGhost#18888 refs TryGhost#18844 - 🐛 Fixed browser focus on editor when clicking card (TryGhost/Koenig#1051) - 🐛 Fixed signup card styles with image background (TryGhost/Koenig#1052) (TryGhost/Koenig#1053) - 🐛 Fixed slash menu having fixed position when scrolling (TryGhost/Koenig#1054) - 🐛 Fixed signup card text color with transparent background (TryGhost/Koenig#1053) - 🐛 Fixed text formats being lost when copy/pasting from Google Docs (TryGhost/Koenig#1055) - 🐛 Fixed pasting link behaviour in single line nested editors (TryGhost/Koenig#1056) - 🐛 Fixed backspace behaviour at start of aside/quote (TryGhost/Koenig#1057) - 🐛 Fixed text having unexpected formats when rendering (TryGhost/Koenig#1058) - 🐛 Fixed placeholder descenders being cut off in nested editor (TryGhost/Koenig#1059) - 🐛 Fixed HTML->Lexical conversion not handling paragraphs inside blockquotes (TryGhost/Koenig#1061)
kevinansfield
added a commit
to TryGhost/Ghost
that referenced
this pull request
Nov 9, 2023
refs #18752, TryGhost/Product#3897, TryGhost/Product#4112, TryGhost/Product#4104, #18866, #18753, TryGhost/Product#4116, #18888, #18844 - 🐛 Fixed browser focus on editor when clicking card ([Koenig/#1051](TryGhost/Koenig#1051)) - 🐛 Fixed signup card styles with image background ([Koenig/#1052](TryGhost/Koenig#1052)) - 🐛 Fixed slash menu having fixed position when scrolling ([Koenig/#1054](TryGhost/Koenig#1054)) - 🐛 Fixed signup card text color with transparent background ([Koenig/#1053](TryGhost/Koenig#1053)) - 🐛 Fixed text formats being lost when copy/pasting from Google Docs ([Koenig/#1055](TryGhost/Koenig#1055)) - 🐛 Fixed pasting link behaviour in single line nested editors ([Koenig/#1056](TryGhost/Koenig#1056)) - 🐛 Fixed backspace behaviour at start of aside/quote ([Koenig/#1057](TryGhost/Koenig#1057)) - 🐛 Fixed text having unexpected formats when rendering ([Koenig/#1058](TryGhost/Koenig#1058)) - 🐛 Fixed placeholder descenders being cut off in nested editor ([Koenig/#1059](TryGhost/Koenig#1059)) - 🐛 Fixed HTML->Lexical conversion not handling paragraphs inside blockquotes ([Koenig/#1061](TryGhost/Koenig#1061))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/TryGhost/Product/issues/4112