Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Descenders of "Toggle header" get cut off #18888

Closed
1 task done
stromfeldt opened this issue Nov 7, 2023 · 0 comments · Fixed by TryGhost/Koenig#1059
Closed
1 task done

Descenders of "Toggle header" get cut off #18888

stromfeldt opened this issue Nov 7, 2023 · 0 comments · Fixed by TryGhost/Koenig#1059
Assignees
@sanne-san
Labels
affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly design P3 - Medium [triage] Bugs which we'll fix soon

Comments

@stromfeldt
Copy link
Contributor

Issue Summary

The "Toggle header" placeholder title for Toggle cards needs some extra line-height as its descenders get cut off.

Xnapper-2023-11-07-10 30 06

Steps to Reproduce

  1. Create a Toggle card
  2. See that the descenders are cut off at the bottom

Ghost Version

5.71.2+moya

Node.js Version

Yes

How did you install Ghost?

Ghost(Pro)

Database type

MySQL 5.7

Browser & OS version

Firefox 119, macOS 13.6

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Nov 7, 2023
@daniellockyer daniellockyer added bug [triage] something behaving unexpectedly affects:editor Work relating to the Koenig Editor design P3 - Medium [triage] Bugs which we'll fix soon and removed needs:triage [triage] this needs to be triaged by the Ghost team labels Nov 7, 2023
@sanne-san sanne-san self-assigned this Nov 9, 2023
sanne-san added a commit to TryGhost/Koenig that referenced this issue Nov 9, 2023
@sanne-san
Fixed placeholder descenders being cut off in nested editors
cdc016e 
Closes TryGhost/Ghost#18888
@sanne-san sanne-san mentioned this issue Nov 9, 2023
Merged
sanne-san added a commit to TryGhost/Koenig that referenced this issue Nov 9, 2023
@sanne-san
Fixed placeholder descenders being cut off in nested editors (#1059)
44afd52 
Closes TryGhost/Ghost#18888
@kevinansfield kevinansfield mentioned this issue Nov 9, 2023
Merged
kevinansfield added a commit to kevinansfield/Ghost that referenced this issue Nov 9, 2023
@kevinansfield
🐛 Fixed various editor issues
d396b20 
refs TryGhost#18752
refs TryGhost/Product#3897
refs TryGhost/Product#4112
refs TryGhost/Product#3802
refs TryGhost/Product#4104
refs TryGhost#18866
refs TryGhost#18753
refs TryGhost/Product#4116
refs TryGhost#18888
refs TryGhost#18844

- 🐛 Fixed browser focus on editor when clicking card (TryGhost/Koenig#1051)
- 🐛 Fixed signup card styles with image background (TryGhost/Koenig#1052)
 (TryGhost/Koenig#1053)
- 🐛 Fixed slash menu having fixed position when scrolling (TryGhost/Koenig#1054)
- 🐛 Fixed signup card text color with transparent background (TryGhost/Koenig#1053)
- 🐛 Fixed text formats being lost when copy/pasting from Google Docs (TryGhost/Koenig#1055)
- 🐛 Fixed pasting link behaviour in single line nested editors (TryGhost/Koenig#1056)
- 🐛 Fixed backspace behaviour at start of aside/quote (TryGhost/Koenig#1057)
- 🐛 Fixed text having unexpected formats when rendering (TryGhost/Koenig#1058)
- 🐛 Fixed placeholder descenders being cut off in nested editor (TryGhost/Koenig#1059)
- 🐛 Fixed HTML->Lexical conversion not handling paragraphs inside blockquotes (TryGhost/Koenig#1061)
kevinansfield added a commit that referenced this issue Nov 9, 2023
@kevinansfield
🐛 Fixed various editor issues (#18934)
30a66da 
refs #18752, TryGhost/Product#3897, TryGhost/Product#4112, TryGhost/Product#4104, #18866, #18753, TryGhost/Product#4116, #18888, #18844

- 🐛 Fixed browser focus on editor when clicking card ([Koenig/#1051](TryGhost/Koenig#1051))
- 🐛 Fixed signup card styles with image background ([Koenig/#1052](TryGhost/Koenig#1052))
- 🐛 Fixed slash menu having fixed position when scrolling ([Koenig/#1054](TryGhost/Koenig#1054))
- 🐛 Fixed signup card text color with transparent background ([Koenig/#1053](TryGhost/Koenig#1053))
- 🐛 Fixed text formats being lost when copy/pasting from Google Docs ([Koenig/#1055](TryGhost/Koenig#1055))
- 🐛 Fixed pasting link behaviour in single line nested editors ([Koenig/#1056](TryGhost/Koenig#1056))
- 🐛 Fixed backspace behaviour at start of aside/quote ([Koenig/#1057](TryGhost/Koenig#1057))
- 🐛 Fixed text having unexpected formats when rendering ([Koenig/#1058](TryGhost/Koenig#1058))
- 🐛 Fixed placeholder descenders being cut off in nested editor ([Koenig/#1059](TryGhost/Koenig#1059))
- 🐛 Fixed HTML->Lexical conversion not handling paragraphs inside blockquotes ([Koenig/#1061](TryGhost/Koenig#1061))
allouis pushed a commit that referenced this issue Nov 15, 2023
@kevinansfield @allouis
🐛 Fixed various editor issues (#18934)
34d41b8 
refs #18752, TryGhost/Product#3897, TryGhost/Product#4112, TryGhost/Product#4104, #18866, #18753, TryGhost/Product#4116, #18888, #18844

- 🐛 Fixed browser focus on editor when clicking card ([Koenig/#1051](TryGhost/Koenig#1051))
- 🐛 Fixed signup card styles with image background ([Koenig/#1052](TryGhost/Koenig#1052))
- 🐛 Fixed slash menu having fixed position when scrolling ([Koenig/#1054](TryGhost/Koenig#1054))
- 🐛 Fixed signup card text color with transparent background ([Koenig/#1053](TryGhost/Koenig#1053))
- 🐛 Fixed text formats being lost when copy/pasting from Google Docs ([Koenig/#1055](TryGhost/Koenig#1055))
- 🐛 Fixed pasting link behaviour in single line nested editors ([Koenig/#1056](TryGhost/Koenig#1056))
- 🐛 Fixed backspace behaviour at start of aside/quote ([Koenig/#1057](TryGhost/Koenig#1057))
- 🐛 Fixed text having unexpected formats when rendering ([Koenig/#1058](TryGhost/Koenig#1058))
- 🐛 Fixed placeholder descenders being cut off in nested editor ([Koenig/#1059](TryGhost/Koenig#1059))
- 🐛 Fixed HTML->Lexical conversion not handling paragraphs inside blockquotes ([Koenig/#1061](TryGhost/Koenig#1061))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanne-san sanne-san

Labels
affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly design P3 - Medium [triage] Bugs which we'll fix soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed placeholder descenders being cut off in nested editors TryGhost/Koenig
3 participants
@daniellockyer @stromfeldt @sanne-san