⚡ Optimized performance of integrity check DB calls #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellockyer
force-pushed
the
perf
branch
2 times, most recently
from
50b8ae9
to
d4a1a7a
Compare
daniellockyer
changed the title
daniellockyer
force-pushed
the
perf
branch
2 times, most recently
from
7b3d711
to
ec46a40
Compare
refs #252 - the referenced issue describes performance problems with the integrity check code in knex-migrator - this commit solves half of the problem - 1 DB call per migration minor version folder - this results in 70+ (and growing!) DB calls at boot, with each one going back and forth to the DB... not efficient - what the code actually needed was a count of how many migrations are currently in the DB, grouped by version - this is very easy to do in SQL and therefore knex - this commit switches the code around to group all the DB migrations first, and then compares against the folders locally - this results in a drop of SQL queries from 70+ to 1 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #252