-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IME problem - especially for CJKT. #11
Conversation
Verified OK on Chrome. Known issue for Safari: the first chinese world is duplicated.
@@ -210,6 +217,43 @@ export default class EventManager { | |||
this._updateModifiersFromKey(key, {isDown:false}); | |||
} | |||
|
|||
compositionstart() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use camelCase instead?
compositionstart() { | |
compositionStart() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, that's the event name.
How to do the re-submit? |
@ErisDS Hi, could you please redo the checks manually? https://travis-ci.com/github/TryGhost/mobiledoc-kit/builds/141700597#L1120 the logs says it failed to request IE11/Edge/Safari environment so that the CI test ended with 3 fails Some lines of logs:
Thanks a lot! |
Please keep non-Ghost-specific PRs on the upstream mobiledoc-kit repository, thank you 🙂 CI will not run on this fork. It's only used for Ghost-specific changes, otherwise it's kept in sync with the main mobiledoc-kit repo. |
Works perfect on Chrome.
Known issue for Safari: the first chinese world is duplicated.