-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QSS: Update Quiet client to detect a v2 invite link format #2310
Comments
I'm missing the clear definition of "v2 invite link". Based on that information - https://docs.google.com/document/d/1dWWwthyJAoNl6sRT5oBGFnuNnYJiU8ZEn7W5Cm1zPRI/edit#heading=h.g05xbtyae2g I would assume that the format looks like that:
So example invitation url would be:
or (if inviter address is just onion address):
@leblowl could you confirm? I think we decided that in first iterations |
I might start with something like: |
One nice thing about having |
Yeah, I was thinking to add this now if it's low cost and not worry about adjusting invitation link format later |
When joining, when a user enters an invite link, Quiet should be able to detect the new invite link format, and if it’s a v2 invite link, then call DOWNLOAD_INVITE_DATA before continuing with the flow.
Mobile launches the deepLink saga on start. We can update deepLinkSaga to detect the invite link type and if it’s a v2 type, call DOWNLOAD_INVITE_DATA and then dispatch the createNetwork action with the returned invite data just like the deepLinkSaga already does.
Desktop deals with parsing the invite data in main.ts and then calls customProtocolSaga. We can simplify things by refactoring customProtocolSaga to act more like mobile’s deepLinkSaga and contain the invite parsing code. In customProtocolSaga, we can also detect if we receive a v2 type link and call DOWNLOAD_INVITE_DATA and then dispatch createNetwork action with the returned invite data.
The text was updated successfully, but these errors were encountered: