Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Colors name overlap in 'Add indicator' modal #308

Closed
2 of 4 tasks
adeacetis opened this issue May 5, 2023 · 0 comments
Closed
2 of 4 tasks

[BUG] Colors name overlap in 'Add indicator' modal #308

adeacetis opened this issue May 5, 2023 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@adeacetis
Copy link
Collaborator

adeacetis commented May 5, 2023

Thanks for reporting an issue, please review the task list below before submitting the issue :

  • I added my browser's console output in the issue (open the console first, try to reproduce the issue then see if there is anything)
  • I have attached an export of my aggr database in the issue
  • I documented the issue with screenshots
  • I provided a clear and concise description of what the bug is (see both sections below)

Describe the issue

I was testing #304 when I noticed that custom colors are overlapping in the 'Add Indicator' modal.

image

I would suggest:

  • truncate the name if it is too long, create two columns layout for this inner section on desktop, colors should be displayed in a single column on mobile

  • optional: add tooltip on desktop to read the whole color's name

Tested on MacBooks OS Ventura 13.3.1 Chrome 112.0.5615.137

...

Steps to reproduce

  1. Get the indicator from issue Please consider adding Vector Candle support #304
  2. Drag and drop the indicator onto a chart panel on charts.aggr.trade
  3. Edit PVRSA indicator

image

4. You should be able to see the UI issues under the COLORS section as per attached attachment. ...
@adeacetis adeacetis added bug Something isn't working good first issue Good for newcomers labels May 5, 2023
@adeacetis adeacetis assigned adeacetis and Tucsky and unassigned adeacetis May 5, 2023
@Tucsky Tucsky closed this as completed in 51d2fc1 May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants