-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blacklist or remove clipboard data like passwords when an application clears it #46
Comments
I'm not sure if we can identify the source of the clipboard, but maybe a "safe copy" shortcut can work? Maybe we can add a shortcut that adds stuff to clipboard without saving it in the app history. WDYT? |
Yeah, I feel bad for raising an issue I don't have a good or clear suggestion for. Shortcut can work, but there's a bit of snag.
Honestly, I get the feeling I need to file an upstream enhancement with gnome/kde/opendesktop.org type places to add a function to clipboard objects that allows permitted applications to query the source process name (which in itself would create a security risk if there was malware hoping to know what exactly to steal from a clipboard...) Without the window manager/shell providing data origin info from the clipboard, the other nasty workaround could be:
|
Just to add a thought about this, another feature or workaround for this is to have an option to store clipboard history in memory rather than storage:
Isn't too hard to do if one can leverage /var/run/user which is mounted with only user access in memory as tmpfs on most distros. But nonetheless, it's not going to help that much given the general insecure state of X and the lack of boundaries between applications running under a single user ID (compare that to Android which has a different user ID for each app). So blacklist is still more ideal. |
I looked into this some more. The registry.txt file used to cache the copy paste history is only only accessible to the user, given However, in cases where people don't use encrypted home directories, or storage, this file could be read in offline attack scenarios (e.g. bootable ISO). I tried a hacky workaround using systemd user mode to move the file into the /var/run/$UID tmpfs location. This mitigates the offline attack, but still has drawbacks:
Again, an option to only cache the history/registry in the extension's process memory space is still better more secure than the example below. Systemd user unit to move registry.txt to a tmpfs mounted locationCreate dir for per user units
Edit
Run/test the service
Enable it for every time the user first logs in
|
#78 adds an option so that the on disk cache / regsistry.txt file won't store clipboard content, inlcuding passwords. However, that knowingly breaks clipboard history persistence between gnome-shell sessions (reboot, logoff & login). Doesn't fix/close this issue. Just a possible mitigation. |
Thinking about it some more, #60 is more or less a duplicate of this? |
So are any password privacy features going to be implemented? |
Hi all. My suggestion would be the same as this. To put an ignore icon near the trash icon. Clicking on the ignore icon would add the entry hash to a blacklist. New clipboard entries would be hashed and the hashes compared to the blacklist. If there is a match the entry is ignored. |
Hi all,
(of course, it does not change the fact that you could accidentally leak things when copying sensitive data off your browser, documents, slack etc.. so it wont addresses all the concerns :( ) |
Sorry, I don't plan on supporting any of these requests.
Sorry for the inconvenience, and good luck! |
As a feature request to make this extension more security friendly, it would be good to have an option to blacklist data that is copied from password managers into the clipboard and/or remove data from the clipboard when an application clears it.
It does sound complicated to look into this given:
For example, applications like KeePass remove the password on the CLIPBOARD after 30 seconds. However, this extension will keep that data and store it its cache/registry file.
Similarly, and issue was logged for GPaste: Application blacklist needed. The solution there, while not ideal, was to add an extra key binding to pop the item out.
It might, at minimum, be possible to detect if the clipboard data is cleared and honor that.
Current workarounds with manual intervention by user
The text was updated successfully, but these errors were encountered: