Updates to revisions class #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed is_authorized() so that it returns the correct result Added tickets field to revision class
Added tickets field to device revisions fixed is_authorized()
DeepSpace2
suggested changes
Jun 14, 2018
|
Does this look good now? |
DeepSpace2
approved these changes
Nov 13, 2019
DeepSpace2
added a commit
that referenced
this pull request
Nov 13, 2019
|
Hi, better late than never... this is merged into master and is available in version 1.2.3 |
DeepSpace2
added a commit
that referenced
this pull request
Nov 14, 2019
* Updates to revisions class (#14) Added tickets attribute to Device_Revision class * Device_Revision - Using an empty list as a default value instead of None for tickets attribute, so iteration still works Version bumped to 1.2.3 * Device_Revision - Fixed a typo in variable name Version bumped to 1.2.4
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue in #13