Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid Skew on large bbox #1505

Closed
cmtoomey opened this issue Oct 4, 2018 · 5 comments
Closed

Grid Skew on large bbox #1505

cmtoomey opened this issue Oct 4, 2018 · 5 comments

Comments

@cmtoomey
Copy link

cmtoomey commented Oct 4, 2018

Similar to #758 - we are getting strange skew for grids that utilize a large bbox (world scale)

Hex
Square

We are seeing similar results in our production application, regardless of grid size.

Square
image

Hex
image

It looks like the fix in #758 didn't resolve this for @turf/square-grid or @turf/hex-grid

@DenisCarriere - is it possible to get this resolved?

cc @mtirwin

@mtirwin
Copy link

mtirwin commented Oct 4, 2018

@DenisCarriere asking because we know you're super close to the issue and the codebase. Even if you don't have time to submit a PR, getting any guidance you can offer on approach would be 👌.

@cmtoomey
Copy link
Author

cmtoomey commented Oct 4, 2018

Additional context - this issue doesn't appear for smaller bounding boxes.

cc @morganherlocker @mourner for potential thoughts on an approach to fix.

@stebogit
Copy link
Collaborator

stebogit commented Oct 5, 2018

@cmtoomey have you read #1059?

I believe it all depends on the projection distortion. You might wanna try playing with @turf/projection and see if that helps when the bbox is large enough to generate the issue.

@rowanwins
Copy link
Member

rowanwins commented Oct 5, 2018

Hi @cmtoomey & @mtirwin

Thanks for reporting the issue, looks like something funky going on, although there is no need to cc in ppl within 2 hours, particularly when they aren't actively involved in the maintenance of the library.

I've just released an alpha of v7 which is a fairly big overhaul of the structure of the lib.

I'll take a look at it when i get a chance but if you've got time to look into the issue feel free.We're open to pull requests against the v7 branch.

Cheers
Rowan

@cmtoomey
Copy link
Author

cmtoomey commented Oct 5, 2018

@rowanwins
Thanks for the note about alpha - our team will look at that and #1059 per @stebogit and see if that can get us a quick fix. The CCs were more to get some internal visibility on the issue - not to cause a small 🔥

We think we have a workaround for now, but if someone could take a look at some point in the future, it would be much appreciated. I'll close for now.

@cmtoomey cmtoomey closed this as completed Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants