Fix jsts empty (Multi)Polygon error @turf/difference #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Major refactoring to `index.js` & `test.js` - Update JSDocs & Typescript definition to support MultiPolygon #721
1 task
|
Thanks a lot @DenisCarriere for taking care of this. 🙇♀️ |
|
:) no worries, going to be pushing this fix in the next release (got 1 more issue to fix in v4.3). |
|
Cool, sure. Will keep posting the updates : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue resolved for #721
Issue was found when the Input had polygons without areas (could resemble a LineString).
index.js&test.jsRef: #644
CC: @rowanwins @amishas157
Red Polygon: Input to apply the difference
Blue Polygon: "empty" Polygon which caused the error