Getting error while finding difference between a multipolygon and a polygon

[amishas157]

I am getting following error while finding the difference betweeen a polygon and a multipolygon.

/Users/AmishaSingla/Documents/osm-adiff-compare/node_modules/@mapbox/osm-compare/node_modules/@turf/difference/node_modules/jsts/dist/jsts.min.js:14
ln.checkValid(this.edgeList.getEdges()),this.graph.addEdges(this.edgeList.getEdges()),this.computeLabelling(),this.labelIncompleteNodes(),this.findResultAreaEdges(t),this.cancelDuplicateResultEdges();var n=new Sn(this.geomFact);n.add(this.graph),this.resultPolyList=n.getPolygons();var i=new wn(this,this.geomFact,this.ptLocator);this.resultLineList=i.build(t);var r=new Ln(this,this.geomFact,this.ptLocator);this.resultPointList=r.build(t),this.resultGeom=this.computeGeometry(this.resultPointList,this.resultLineList,this.resultPolyList,t)},labelIncompleteNode:function(t,e){var n=this.ptLocator.locate(t.getCoordinate(),this.arg[e].getGeometry());t.getLabel().setLocation(e,n)},copyPoints:function(t){for(var e=this.arg[t].getNodeIterator();e.hasNext();){var n=e.next(),i=this.graph.addNode(n.getCoordinate());i.setLabel(t,n.getLabel().getLocation(t))}},findResultAreaEd

The polygon and multipolygon are following:

• http://bl.ocks.org/d/44385641e432c52cdfd548218454fd42
• http://bl.ocks.org/d/28768027d930ce93f0798fa6f6463fad

Source Code:
https://jsfiddle.net/tboq1cv5/

Not sure if the input to difference method is right or not.

cc @rowanwins @DenisCarriere

[rowanwins]

Hi @amishas157

This is likely due to the same issue previously around jsts not supporting multipolygons very well.

Also as an FYI - in jsfiddle you can add an external resource like the minified version of turf with the url https://npmcdn.com/@turf/turf/turf.min.js. then rather the require failing you can just say turf.difference(feature, feature2). Check out this example and open the console to see the result, In this case I just took one part of your multipoly and it works fine, so yeah Im pretty sure its the multipoly thing.

Cheers

[amishas157]

Whoops cool. Thank for the turfy information. : ) Will try it sure.

[DenisCarriere]

Looks like @turf/difference doesn't support MultiPolygon, however now that we've got a spiffy flattenEach method we could iterate over each flattened Polygon and apply the same jsts difference operations. This shouldn't be to hard to include, @amishas157 let me look into this.

[DenisCarriere]

@amishas157 Looks like the 2nd Multi-Polygon is really a LineString (seems like the issue is coming from jsts).

Solution (quick fix):

We could remove empty polygons prior to performing the difference operations.

[amishas157]

@DenisCarriere Little confused, do we need to use flattenEach method or do any preprocessing before applying difference operation?

[DenisCarriere]

No, the issue wasn't the MultiPolygon, it was related to empty polygons.
In the next release you won't have to change anything in your code, the fix excludes those empty polygon geometries.

[DenisCarriere]

@amishas157 Just released a patch release v4.2.1 @turf/difference, try it out now and let me know if this fixed the issue for you.

Note: This won't be fixed in the main TurfJS library, changes only apply in @turf/difference.

[amishas157]

Wohooo 🎉 On it.

[amishas157]

Hey @DenisCarriere 👋 I tried running this code sinppet https://jsfiddle.net/tboq1cv5/ but looks like it is giving the error. Can you confirm once?

[DenisCarriere]

@amishas157 Looks like patch release didn't include the newest changes (must of published v4.2.1 on a different branch 🤦‍♂️ ).

Ok I've published another patch release v4.2.2 and this one I can confirm does work! 👍

Lesson learned.. don't publish npm releases before going to bed at 1:30am 🛏

[amishas157]

Ok I've published another patch release v4.2.2 and this one I can confirm does work! 👍

🙇‍♀️

Lesson learned.. don't publish npm releases before going to bed at 1:30am 🛏

Yes, That time is meant for sleeping 😴 and work 🙅‍♂️ .

[amishas157]

@DenisCarriere , oops I think we need to also publish a new package for turf-invariant, which has got getGeom method and use that in turrf-difference, coz right now i see this error:

/Users/AmishaSingla/Documents/experiments/node_modules/@turf/difference/index.js:52
    var geom1 = getGeom(polygon1);
                ^

TypeError: getGeom is not a function
    at module.exports (/Users/AmishaSingla/Documents/experiments/node_modules/@turf/difference/index.js:52:17)
    at Object.<anonymous> (/Users/AmishaSingla/Documents/experiments/turf-experiment.js:316:13)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)
    at startup (node.js:139:18)
    at node.js:968:3

[DenisCarriere]

Strange that I didn't get that error, might be my local environnement. Ok let's wait and test this again until I publish all the other repos

[DenisCarriere]

@amishas157 Just published v4.3.0, let me know if this issue is still happening on other data.

I used @rowanwins's approach and everything seems to work: https://jsfiddle.net/yjctqtc6/

Feel free to close if it's resolve 👍

[amishas157]

Awesome, this works 💯 . Thanks @DenisCarriere :)