-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Era week number test #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uring-Eras/api into era_week_number_test
leahriffell
reviewed
Jan 6, 2021
leahriffell
reviewed
Jan 6, 2021
leahriffell
reviewed
Jan 6, 2021
leahriffell
reviewed
Jan 6, 2021
AngelaGuardia
requested changes
Jan 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @LHJE! Left some comments for some changes.
…uring-Eras/api into era_week_number_test
…ek_number_test
Co-authored-by: Angela Guardia <angelaguardia20@gmail.com>
LHJE
commented
Jan 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments! Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Highlights:
create_era.rb
to accept theweek_number
argumentcreate_era.rb
to calculate week_numberupdate_era.rb
to accept theweek_number
argumentupdate_era.rb
to calculate week_numbercreate_era_spec.rb
to takeweek_number
into considerationupdate_era_spec.rb
to takeweek_number
into considerationget_single_era_spec.rb
to testweekNumber
being exposedWhere should the reviewer start?
create_era_spec.rb
andupdate_era_spec.rb
Have Tests Been Added?
Any background context you want to provide?
Message/Questions for reviewer:
Issues:
Screenshots (if appropriate):
Tracking Consistency:
get_users
one