-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Week number to events and eras #81
Conversation
Thanks, Luke! Should we also assert presence of week_num in the events and eras models+specs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Luke! I agree with @leahriffell. Let's add that week presence validation to the models and this will be ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change!
@@ -5,6 +5,7 @@ def change | |||
t.string :name | |||
t.date :start_date | |||
t.date :end_date | |||
t.integer :week_number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eras should have a start_week and end_week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got iiiit! Okay cool! I'll have that working today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to go!
I tried adding the model tests to your branch (validate week num presence on eras/events) but it actually broke all of the tests and factories that didn't have these. I see in your later PR you add these in so I think we should add the model specs to that PR. I'll merge this one and then we can add model specs to that one! |
Code Highlights:
week_number
to Eras and Events migrations, and subsequently the schemaWhere should the reviewer start?
Have Tests Been Added?
Any background context you want to provide?
Message/Questions for reviewer:
Issues:
Screenshots (if appropriate):
Tracking Consistency: