-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples from BUGS volume 2 #186
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Pull Request Test Coverage Report for Build 9747173277Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sunxd3 looks good; do we cover all BUGS models in Vol 1 and Vol 2? |
Other than the last four examples from Vol 2, all examples from Vol 1 and 2 are here. I didn't include those examples because either they are not examples on doing inferences (https://www.multibugs.org/examples/latest/Stagnant.html) or they are not very illustrative. I tried doing HMC (or NUTS) on pretty much all the examples, the results are here. Most examples actually just work. The biggest failure mode is discrete random variable, for instance a ~ dcat() # Categorical
b ~ dnorm(c[a], 1) the issue here is a is casted into a float (TrackedReal), but the conversion back to Int is not defined for |
Fix #133 (also #188, which seems to be a numerical thing, fixed by using approximately equality test)