fix: Allow binding IPv6 addresses for web #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #650 +/- ##
=======================================
Coverage 78.49% 78.49%
=======================================
Files 58 58
Lines 4705 4705
=======================================
Hits 3693 3693
Misses 827 827
Partials 185 185 ☔ View full report in Codecov by Sentry. |
|
@n-thumann Thank you for your contribution! |
github-merge-queue bot
pushed a commit
to chezmoi-sh/atlas
that referenced
this pull request
Mar 23, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | OpenSSF | |---|---|---|---| | [TwiN/gatus](https://togithub.com/TwiN/gatus) | minor | `v5.7.0` -> `v5.8.0` | [](https://securityscorecards.dev/viewer/?uri=github.com/TwiN/gatus) | --- ### Release Notes <details> <summary>TwiN/gatus (TwiN/gatus)</summary> ### [`v5.8.0`](https://togithub.com/TwiN/gatus/releases/tag/v5.8.0) [Compare Source](https://togithub.com/TwiN/gatus/compare/v5.7.0...v5.8.0) ##### What's Changed - feat(client): Add Google's Identity-Aware-Proxy in client config by [@​Kloox](https://togithub.com/Kloox) in [TwiN/gatus#600 - feat(client): Add client network configuration for ICMP endpoint clients by [@​n-thumann](https://togithub.com/n-thumann) in [TwiN/gatus#661 - feat(http): enhance HTTP client configuration with proxy support by [@​appleboy](https://togithub.com/appleboy) in [TwiN/gatus#668 - feat: add ability to delay startup by [@​vax-r](https://togithub.com/vax-r) in [TwiN/gatus#631 - feat: shields.io endpoint badge by [@​buroa](https://togithub.com/buroa) in [TwiN/gatus#652 - fix(web): Allow configuration of read-buffer-size by [@​TwiN](https://togithub.com/TwiN) in [TwiN/gatus#675 - fix: Allow binding IPv6 addresses for web by [@​n-thumann](https://togithub.com/n-thumann) in [TwiN/gatus#650 - build: refine Makefile targets and build command by [@​appleboy](https://togithub.com/appleboy) in [TwiN/gatus#666 - refactor(alerting): Use pointer for receiver in AlertProvider.GetDefaultAlert method by [@​TwiN](https://togithub.com/TwiN) in [TwiN/gatus#676 - docs(alerting): Fix wrong gitlab terminology (alert key vs. PAT) by [@​salim-b](https://togithub.com/salim-b) in [TwiN/gatus#694 - chore(deps): bump actions/setup-go from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#634 - chore(deps): bump golang.org/x/crypto from 0.14.0 to 0.18.0 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#649 - chore(deps): bump modernc.org/sqlite from 1.26.0 to 1.28.0 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#654 - chore(deps): bump codecov/codecov-action from 3.1.4 to 3.1.6 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#669 - chore(deps): bump codecov/codecov-action from 3.1.6 to 4.0.1 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#671 - chore(deps): bump github.com/prometheus/client_golang from 1.17.0 to 1.18.0 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#658 - chore(deps): bump github.com/gofiber/fiber/v2 from 2.49.2 to 2.52.1 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#682 - chore(deps): bump github.com/TwiN/deepmerge from 0.2.0 to 0.2.1 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#684 - chore(deps): bump golang.org/x/oauth2 from 0.13.0 to 0.18.0 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#701 ##### New Contributors - [@​Kloox](https://togithub.com/Kloox) made their first contribution in [TwiN/gatus#600 - [@​n-thumann](https://togithub.com/n-thumann) made their first contribution in [TwiN/gatus#650 - [@​buroa](https://togithub.com/buroa) made their first contribution in [TwiN/gatus#652 **Full Changelog**: TwiN/gatus@v5.7.0...v5.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/chezmoi-sh/nex.rpi). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
xunleii
pushed a commit
to chezmoi-sh/atlas
that referenced
this pull request
May 19, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | OpenSSF | |---|---|---|---| | [TwiN/gatus](https://togithub.com/TwiN/gatus) | minor | `v5.7.0` -> `v5.8.0` | [](https://securityscorecards.dev/viewer/?uri=github.com/TwiN/gatus) | --- ### Release Notes <details> <summary>TwiN/gatus (TwiN/gatus)</summary> ### [`v5.8.0`](https://togithub.com/TwiN/gatus/releases/tag/v5.8.0) [Compare Source](https://togithub.com/TwiN/gatus/compare/v5.7.0...v5.8.0) ##### What's Changed - feat(client): Add Google's Identity-Aware-Proxy in client config by [@​Kloox](https://togithub.com/Kloox) in [TwiN/gatus#600 - feat(client): Add client network configuration for ICMP endpoint clients by [@​n-thumann](https://togithub.com/n-thumann) in [TwiN/gatus#661 - feat(http): enhance HTTP client configuration with proxy support by [@​appleboy](https://togithub.com/appleboy) in [TwiN/gatus#668 - feat: add ability to delay startup by [@​vax-r](https://togithub.com/vax-r) in [TwiN/gatus#631 - feat: shields.io endpoint badge by [@​buroa](https://togithub.com/buroa) in [TwiN/gatus#652 - fix(web): Allow configuration of read-buffer-size by [@​TwiN](https://togithub.com/TwiN) in [TwiN/gatus#675 - fix: Allow binding IPv6 addresses for web by [@​n-thumann](https://togithub.com/n-thumann) in [TwiN/gatus#650 - build: refine Makefile targets and build command by [@​appleboy](https://togithub.com/appleboy) in [TwiN/gatus#666 - refactor(alerting): Use pointer for receiver in AlertProvider.GetDefaultAlert method by [@​TwiN](https://togithub.com/TwiN) in [TwiN/gatus#676 - docs(alerting): Fix wrong gitlab terminology (alert key vs. PAT) by [@​salim-b](https://togithub.com/salim-b) in [TwiN/gatus#694 - chore(deps): bump actions/setup-go from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#634 - chore(deps): bump golang.org/x/crypto from 0.14.0 to 0.18.0 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#649 - chore(deps): bump modernc.org/sqlite from 1.26.0 to 1.28.0 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#654 - chore(deps): bump codecov/codecov-action from 3.1.4 to 3.1.6 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#669 - chore(deps): bump codecov/codecov-action from 3.1.6 to 4.0.1 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#671 - chore(deps): bump github.com/prometheus/client_golang from 1.17.0 to 1.18.0 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#658 - chore(deps): bump github.com/gofiber/fiber/v2 from 2.49.2 to 2.52.1 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#682 - chore(deps): bump github.com/TwiN/deepmerge from 0.2.0 to 0.2.1 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#684 - chore(deps): bump golang.org/x/oauth2 from 0.13.0 to 0.18.0 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#701 ##### New Contributors - [@​Kloox](https://togithub.com/Kloox) made their first contribution in [TwiN/gatus#600 - [@​n-thumann](https://togithub.com/n-thumann) made their first contribution in [TwiN/gatus#650 - [@​buroa](https://togithub.com/buroa) made their first contribution in [TwiN/gatus#652 **Full Changelog**: TwiN/gatus@v5.7.0...v5.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/chezmoi-sh/nex.rpi). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
xunleii
pushed a commit
to chezmoi-sh/atlas
that referenced
this pull request
May 19, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | OpenSSF | |---|---|---|---| | [TwiN/gatus](https://togithub.com/TwiN/gatus) | minor | `v5.7.0` -> `v5.8.0` | [](https://securityscorecards.dev/viewer/?uri=github.com/TwiN/gatus) | --- ### Release Notes <details> <summary>TwiN/gatus (TwiN/gatus)</summary> ### [`v5.8.0`](https://togithub.com/TwiN/gatus/releases/tag/v5.8.0) [Compare Source](https://togithub.com/TwiN/gatus/compare/v5.7.0...v5.8.0) ##### What's Changed - feat(client): Add Google's Identity-Aware-Proxy in client config by [@​Kloox](https://togithub.com/Kloox) in [TwiN/gatus#600 - feat(client): Add client network configuration for ICMP endpoint clients by [@​n-thumann](https://togithub.com/n-thumann) in [TwiN/gatus#661 - feat(http): enhance HTTP client configuration with proxy support by [@​appleboy](https://togithub.com/appleboy) in [TwiN/gatus#668 - feat: add ability to delay startup by [@​vax-r](https://togithub.com/vax-r) in [TwiN/gatus#631 - feat: shields.io endpoint badge by [@​buroa](https://togithub.com/buroa) in [TwiN/gatus#652 - fix(web): Allow configuration of read-buffer-size by [@​TwiN](https://togithub.com/TwiN) in [TwiN/gatus#675 - fix: Allow binding IPv6 addresses for web by [@​n-thumann](https://togithub.com/n-thumann) in [TwiN/gatus#650 - build: refine Makefile targets and build command by [@​appleboy](https://togithub.com/appleboy) in [TwiN/gatus#666 - refactor(alerting): Use pointer for receiver in AlertProvider.GetDefaultAlert method by [@​TwiN](https://togithub.com/TwiN) in [TwiN/gatus#676 - docs(alerting): Fix wrong gitlab terminology (alert key vs. PAT) by [@​salim-b](https://togithub.com/salim-b) in [TwiN/gatus#694 - chore(deps): bump actions/setup-go from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#634 - chore(deps): bump golang.org/x/crypto from 0.14.0 to 0.18.0 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#649 - chore(deps): bump modernc.org/sqlite from 1.26.0 to 1.28.0 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#654 - chore(deps): bump codecov/codecov-action from 3.1.4 to 3.1.6 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#669 - chore(deps): bump codecov/codecov-action from 3.1.6 to 4.0.1 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#671 - chore(deps): bump github.com/prometheus/client_golang from 1.17.0 to 1.18.0 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#658 - chore(deps): bump github.com/gofiber/fiber/v2 from 2.49.2 to 2.52.1 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#682 - chore(deps): bump github.com/TwiN/deepmerge from 0.2.0 to 0.2.1 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#684 - chore(deps): bump golang.org/x/oauth2 from 0.13.0 to 0.18.0 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#701 ##### New Contributors - [@​Kloox](https://togithub.com/Kloox) made their first contribution in [TwiN/gatus#600 - [@​n-thumann](https://togithub.com/n-thumann) made their first contribution in [TwiN/gatus#650 - [@​buroa](https://togithub.com/buroa) made their first contribution in [TwiN/gatus#652 **Full Changelog**: TwiN/gatus@v5.7.0...v5.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/chezmoi-sh/nex.rpi). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
xunleii
pushed a commit
to chezmoi-sh/atlas
that referenced
this pull request
May 19, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | OpenSSF | |---|---|---|---| | [TwiN/gatus](https://togithub.com/TwiN/gatus) | minor | `v5.7.0` -> `v5.8.0` | [](https://securityscorecards.dev/viewer/?uri=github.com/TwiN/gatus) | --- ### Release Notes <details> <summary>TwiN/gatus (TwiN/gatus)</summary> ### [`v5.8.0`](https://togithub.com/TwiN/gatus/releases/tag/v5.8.0) [Compare Source](https://togithub.com/TwiN/gatus/compare/v5.7.0...v5.8.0) ##### What's Changed - feat(client): Add Google's Identity-Aware-Proxy in client config by [@​Kloox](https://togithub.com/Kloox) in [TwiN/gatus#600 - feat(client): Add client network configuration for ICMP endpoint clients by [@​n-thumann](https://togithub.com/n-thumann) in [TwiN/gatus#661 - feat(http): enhance HTTP client configuration with proxy support by [@​appleboy](https://togithub.com/appleboy) in [TwiN/gatus#668 - feat: add ability to delay startup by [@​vax-r](https://togithub.com/vax-r) in [TwiN/gatus#631 - feat: shields.io endpoint badge by [@​buroa](https://togithub.com/buroa) in [TwiN/gatus#652 - fix(web): Allow configuration of read-buffer-size by [@​TwiN](https://togithub.com/TwiN) in [TwiN/gatus#675 - fix: Allow binding IPv6 addresses for web by [@​n-thumann](https://togithub.com/n-thumann) in [TwiN/gatus#650 - build: refine Makefile targets and build command by [@​appleboy](https://togithub.com/appleboy) in [TwiN/gatus#666 - refactor(alerting): Use pointer for receiver in AlertProvider.GetDefaultAlert method by [@​TwiN](https://togithub.com/TwiN) in [TwiN/gatus#676 - docs(alerting): Fix wrong gitlab terminology (alert key vs. PAT) by [@​salim-b](https://togithub.com/salim-b) in [TwiN/gatus#694 - chore(deps): bump actions/setup-go from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#634 - chore(deps): bump golang.org/x/crypto from 0.14.0 to 0.18.0 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#649 - chore(deps): bump modernc.org/sqlite from 1.26.0 to 1.28.0 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#654 - chore(deps): bump codecov/codecov-action from 3.1.4 to 3.1.6 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#669 - chore(deps): bump codecov/codecov-action from 3.1.6 to 4.0.1 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#671 - chore(deps): bump github.com/prometheus/client_golang from 1.17.0 to 1.18.0 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#658 - chore(deps): bump github.com/gofiber/fiber/v2 from 2.49.2 to 2.52.1 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#682 - chore(deps): bump github.com/TwiN/deepmerge from 0.2.0 to 0.2.1 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#684 - chore(deps): bump golang.org/x/oauth2 from 0.13.0 to 0.18.0 by [@​dependabot](https://togithub.com/dependabot) in [TwiN/gatus#701 ##### New Contributors - [@​Kloox](https://togithub.com/Kloox) made their first contribution in [TwiN/gatus#600 - [@​n-thumann](https://togithub.com/n-thumann) made their first contribution in [TwiN/gatus#650 - [@​buroa](https://togithub.com/buroa) made their first contribution in [TwiN/gatus#652 **Full Changelog**: TwiN/gatus@v5.7.0...v5.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/chezmoi-sh/nex.rpi). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #532.
According to https://docs.gofiber.io/api/fiber#config, Fiber listens on IPv4-only by default. This is the reason why no IPv6 addresses can be bound.
This PR changes the
NetworkfromNetworkTCP4toNetworkTCP, allowing both IPv4 and IPv6 (see https://pkg.go.dev/net#Listen).Binding to the unspecified IPv4 or IPv6 address (
0.0.0.0or[::]) will make it listen on both IPv4 and IPv6. Binding a specific IPv4 or IPv6 address will make it listen on that specific address only.Checklist
README.md, if applicable.