Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane type identification shall be moved to shortly before creation #97

Closed
2 tasks done
TwinFan opened this issue Feb 10, 2019 · 1 comment
Closed
2 tasks done
Assignees
Labels
bug Something isn't working confirmed Bug confirmed, reproducible.
Milestone

Comments

@TwinFan
Copy link
Owner

TwinFan commented Feb 10, 2019

Current Situation / Problem

  1. Many message that data is lacking ICAO type code, which later becomes obsolete as often the type code is received in subsequent network responses.
  2. Sometimes ground vehicle identification fails as the GND flag in the tracking data is unreliable and sometimes false...for ground vehicle I insist however that they are on the ground :)

Suggested Solution

  • Move type identification including warnings about missing types to shortly before the aircraft gets actually created. By that time all reasonable information is available for an educated guess.
  • Reconsider plane type with new info (type code, airline, livery, GND flag changing) becoming available. Does occasionally happen, e.g. if later another channel sees the plane and has the correct type. The multiplayer lib allows to change the model using XPMPChangePlaneModel, which performs a new CSL match.

Benefits
Better model guess. Less annoying messages.

Additional context
Elios000 reports regular wrong ground vehicles in KLAX, see Discord.

@TwinFan TwinFan self-assigned this Feb 10, 2019
@TwinFan TwinFan added bug Something isn't working confirmed Bug confirmed, reproducible. labels Feb 10, 2019
@TwinFan TwinFan added this to the v1.0 milestone Feb 10, 2019
@TwinFan
Copy link
Owner Author

TwinFan commented Feb 17, 2019

As we now have LTAircraft::UpdateModel we also added updating of all models if users loads new CSL models in Settings > CSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed Bug confirmed, reproducible.
Projects
None yet
Development

No branches or pull requests

1 participant