Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side-effect on std::convert::Into<_> introduced in 0.1.12 #22

Closed
behnam opened this issue Jun 16, 2017 · 10 comments
Closed

Side-effect on std::convert::Into<_> introduced in 0.1.12 #22

behnam opened this issue Jun 16, 2017 · 10 comments

Comments

@behnam
Copy link

behnam commented Jun 16, 2017

As the 0.1.12 update yesterday, I noticed that building lib unit tests is failing in unicode-bidi with flame_it feature. I went back and minimized the changes for the break, which actually reduced to only extern crate flame;, and only happening for =0.1.12.

Here's the commit causing error on a stable unicode-bidi build: behnam/rust-unicode-bidi@6e6fc78

Here's the error:

error[E0283]: type annotations required: cannot resolve `level::Level: std::convert::Into<_>`
   --> src/level.rs:331:31
    |
331 |         assert_eq!(1u8, level.into());
    |                               ^^^^

error: aborting due to previous error

from https://travis-ci.org/behnam/rust-unicode-bidi/jobs/243806493#L259

I have no idea how flame can cause this in a module that doesn't use any of the traits. What do you think, @TyOverby ?

@TyOverby
Copy link
Collaborator

Could it be an issue with flame changing transitive dependencies?

@behnam
Copy link
Author

behnam commented Jun 17, 2017

Hum... not sure what you mean by transitive dependencies.

I'm looking at git diff 590014d e1cf412 and can't find anything suspicious.

@TyOverby
Copy link
Collaborator

@behnam I mean, could adding flame as a dependency change the versions of other dependencies in your project?

@TyOverby
Copy link
Collaborator

@behnam: any update on this? I don't think that this is the fault of bincode.

@behnam
Copy link
Author

behnam commented Jul 7, 2017

No updates here, @TyOverby . I guess it's a version conflict for serde_derive stuff, but I don't find it.

@TyOverby
Copy link
Collaborator

TyOverby commented Jul 8, 2017

If this still repros for you, could you send me the contents of your Cargo.lock file before and after?

Also try building flame with and without the json feature enabled.

@behnam
Copy link
Author

behnam commented Jul 15, 2017

@behnam
Copy link
Author

behnam commented Jul 15, 2017

Also, I disabled default flame features, but still got the same error.

@TyOverby
Copy link
Collaborator

your before/after cargo.lock.toml files are identical

@TyOverby
Copy link
Collaborator

Closing due to inactivity; please reopen if this is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants