Display bin image file as image. #17
Conversation
|
That's very interesting. We didn't think about encrypted images. Currently, I didn't even think it would support it because the maximal file size is so low and we don't bother with checking if it's binary or not. So:
Nice idea anyway. I'll prompt the community about this. |
|
Here is the example: I don't know what is the file limit but since it is a TextArea I don't think it is a problem. |
|
It could be even better to implement the drag and drop in the textarea as it works with Github. |
|
Ok. If we implement your other issue, we would have the mime/type, so we could definitly add this image feature. It would probably require to seriously clean up the code because it's not modular at all for now: the workflow is kinda one big block. But it seems with it. Drag and drop as well, but it should be another opened issue. |
|
Hello, We are interested too. But TBH, i personnally know natim ;) In fact, we are looking for a pastebin and imagebin ( http://imagebin.org/ ) to be installed on our own server, in order to not rely on external service like friendpaste ou gist. Regarding the file size, since we have installed it locally, we can maximize withtout trouble. Apology for my english. Regards, |
|
Very good. I'm glad you wish to install that on your own server. The Le 02/01/2013 13:37, scostes a écrit :
|
|
I'm not just wishing, i've already done it ;) I'm looking forward to pip upgrade it and have image paste support |
|
\o/ Le 02/01/2013 14:19, scostes a écrit :
|
|
I need to work a little bit more to handle encryption error with some jpg files, but the result so far is quite nice. |
|
Actually it seams that bottle cut the request body on too big messages. That's a shame but it seams to be the normal behavior over http the good solution, would be to send it has a file so it would be chunked. |
…ryption key - futhermore if you run 0bin over SSH.
|
Don't hesitate to contact me if you need explanation. |
|
Ok, that's a big piece of work. I'll need some time to review it. I'll give it a try on monday morning. |
|
I haven't forgot to check the code. It's cloned on my machine, it's just I couldn't find a good time to review it. Sorry for the delay. |
|
"Je suis tellement impatient ;)" |
|
i've seen a demo, looks great from the user side ! |
|
A full working version of all these PR is available here : https://github.com/novagile/0bin on master. |
|
Hi man, Sorry I took so much time to review this. I checkout your master and some commits here and there to be sure, but I can't make it work. When I'm on Firefox (18.0.1), uploading the jped file just doesn't work (no error displayed in the Python / JS console). When I use Chrome, I do save the image successfully, but it spit me back the binarie data instead of dispaying the image. I'm using Ubuntu, so it could be a mime/type detection issue but I could find it by scanning the code. |
|
Are you sure that the js file loaded is up-to-date? |
|
Ok I suck, I just emptied my cache and it worked perfectly. |
|
Ok done but we need to create a ticket to let the choice for is.gd. |
|
Here you are #25 |
|
When I click on "merge pull request", it still offer me to merge #17. I'm not sure but I think you can update the original pull request itself t the choosen commit on the PR page. |
|
Yes I merge everything I did in the #17 PR |
Display bin image file as image.
|
I merged it, but it merged the google url shortener change as well. It's not the end of the world I guess. |
|
It is why #25 exists ;) |
|
Anyway, thanks for the work, Natim. It's nice to have people involved. |
No description provided.