Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestVirtualEndpoint fails with race #2374

Closed
furkansenharputlu opened this issue Jul 4, 2019 · 0 comments · Fixed by #2389
Closed

TestVirtualEndpoint fails with race #2374

furkansenharputlu opened this issue Jul 4, 2019 · 0 comments · Fixed by #2389
Labels
bug test-failure Intermittent test failure in CI

Comments

@furkansenharputlu
Copy link
Contributor

furkansenharputlu commented Jul 4, 2019 •
edited
Loading

This race causes test to fail. However, it is a bug. While SuccessHandler.RecordHit runs in a different goroutine and modifies response. It causes the race.
@furkansenharputlu furkansenharputlu added the test-failure Intermittent test failure in CI label Jul 4, 2019
@furkansenharputlu furkansenharputlu changed the title TestVirtualEndpoint race TestVirtualEndpoint fails with race Jul 4, 2019
@furkansenharputlu furkansenharputlu mentioned this issue Jul 10, 2019
Merged
buger pushed a commit that referenced this issue Jul 10, 2019
@furkansenharputlu @buger
Fix race condition that occurs during TestVirtualEndpoint (#2389)
6f2c894 
Fixes #2374
buger pushed a commit that referenced this issue Jul 10, 2019
@furkansenharputlu @buger
Fix race condition that occurs during TestVirtualEndpoint (#2389)
de5f513 
Fixes #2374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug test-failure Intermittent test failure in CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix race condition that occurs during TestVirtualEndpoint furkansenharputlu/tyk
1 participant
@furkansenharputlu