Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition that occurs during TestVirtualEndpoint #2389

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Fix race condition that occurs during TestVirtualEndpoint #2389

merged 2 commits into from
Jul 10, 2019

Conversation

furkansenharputlu
Copy link
Contributor

Fixes #2374

@furkansenharputlu furkansenharputlu self-assigned this Jul 10, 2019
@buger
Copy link
Member

buger commented Jul 10, 2019

Not a fan of such a solution, because it is quite slow...
I wonder if we can just remove using goroutine here, and run it directly?
Analytics pipeline is async anyway and has own goroutine pool.

@buger buger merged commit 6f2c894 into TykTechnologies:master Jul 10, 2019
buger pushed a commit that referenced this pull request Jul 10, 2019
@furkansenharputlu @buger
Fix race condition that occurs during TestVirtualEndpoint (#2389)
de5f513 
Fixes #2374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@furkansenharputlu furkansenharputlu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestVirtualEndpoint fails with race
2 participants
@furkansenharputlu @buger