-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: remove net/context #1937
Closed
matiasinsaurralde
wants to merge
47
commits into
TykTechnologies:master
from
matiasinsaurralde:remove-vendored-context
Closed
vendor: remove net/context #1937
matiasinsaurralde
wants to merge
47
commits into
TykTechnologies:master
from
matiasinsaurralde:remove-vendored-context
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e353a70.
This reverts commit f41cd8f.
Currently it slams MDCB a lot, can cause lot of login requests when there is issue with login (like hybrid not enabled). Additionally added timeout to CheckReload function, when request returns error (and in this case does not apply internal timeout). Improved cert pining logging
`getVersionFromRequest` do not get in account `NotVersioned` flag, and UI by default writes `a.VersionDefinition.Location` field, so this check for version inside url was running for all non versioned APIs. In case of cloud it was causing panics, because nginx layer maps `slug` to `listenpath` and actual user URL does not contain listen path, and can be even smaller (which cause panic). Replaced manual array operation with `strings.TrimPrefix` which checks array bounds, and added support for stripping slug from URL too (for cloud case).
fixes TykTechnologies#1799 Set `"max_idle_connections_per_host": 500` where previously was capped at 100. Ensure `"close_connections":false` is the default.
Fixes TykTechnologies#1755 This ensures that if a token goes over it's rate-limit, it does not count towards the global / api-level rate-limit.
Fixes TykTechnologies#1622 Fixes TykTechnologies#1640 bcrypt is slow by design. We are able to get approx 10rps for basic auth natively due to bcrypt. bench-no-cache 10 137680538 ns/op 1343793 B/op 26030 allocs/op bench-cache-valid 1000 1689715 ns/op 104782 B/op 774 allocs/op This PR bypasses bcrypt validation when that password has already been validated. cache enabled ttl. default 60s
* jsvm: modify bundle behavior when using JSVM (TykTechnologies#1839) * api_loader: avoid calling LoadJSPaths when using gRPC or Python drivers
Fixes: TykTechnologies#1879 It was not using "quota-" prefix.
…into release-2.7
…eware doesn't return a session object, fixes TykTechnologies#1279 Under this scenario (no session object) we assume the authentication has failed.
Addresses one of issues in TykTechnologies#1880 I couldnt consistently reproduce the behaviour but sometime when tyk lint is run tyk process will start up afterwards. This is not the advertised behaviour of the linter currently - so this change guarantees exit. We can change behaviour by attaching flags to the command at a future time.
* enable inialisation of tls client for dash comms * remove unneccesary code in client initialisation
…k skew (TykTechnologies#1741) [This fix ](TykTechnologies@abb1b35 )helps to avoid jwt failure but can risk us since it won't validate the time-related claims at all (using disable config fields in api def). I have added a field that gives leeway ,in seconds, in case there is a clock skew times between the signing server (Idp for instance) and the verifying server, i.e. Tyk. Have added tests for both type of fields - disable time claims validation and added leeway to time claims validation.
* api_loader: use mwDriver as the middleware driver, fixes TykTechnologies#1887 * coprocess_bundle: only call HandleMiddlewareCache when using rich plugins
* coprocess: fix Python memory issues Added Python refcount macros. Modified the C.free calls to avoid any GC issues. Python_DispatchHook uses memcpy to avoid accessing the internal buffer of the resulting PyObject. * coprocess: modify Lua code to match dispatcher arguments * coprocess: add error results
Should check if JSVM enabled before loading JS files
Closing in favor of #1954 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes the errors during tests:
go test -tags 'coprocess grpc'
From the official source code here: