Enable inialisation of tls client for dash comms #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblakeley
force-pushed
the
gatewaytlsclient
branch
from
a10299f
to
afed427
Compare
|
Sorry for the late review. I think you overdid it a bit. Passing In this case we need only option to ignore certificate verification for the dashboard connections. Using existing config as you did should be fine. Moving to in-progress for now. |
|
👍 Will be part of 2.7.2 |
buger
pushed a commit
that referenced
this pull request
Aug 16, 2018
* enable inialisation of tls client for dash comms * remove unneccesary code in client initialisation
buger
pushed a commit
that referenced
this pull request
Sep 25, 2018
* enable inialisation of tls client for dash comms * remove unneccesary code in client initialisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1806