Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable inialisation of tls client for dash comms #1850

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Conversation

joshblakeley
Copy link
Member

Fixes #1806

@joshblakeley joshblakeley requested a review from buger August 1, 2018 15:18
@buger
Copy link
Member

buger commented Aug 6, 2018

Sorry for the late review. I think you overdid it a bit.

Passing NameToCertificate and Certificates to TLS client is too much. NameToCertificate for example used only by TLS servers, and passing Certificates for client, used only in mutual TLS flow.

In this case we need only option to ignore certificate verification for the dashboard connections. Using existing config as you did should be fine.

Moving to in-progress for now.

@buger
Copy link
Member

buger commented Aug 9, 2018

👍

Will be part of 2.7.2

@buger buger merged commit a30cc5e into master Aug 9, 2018
@buger buger deleted the gatewaytlsclient branch August 9, 2018 13:38
buger pushed a commit that referenced this pull request Aug 16, 2018
* enable inialisation of tls client for dash comms

* remove unneccesary code in client initialisation
buger pushed a commit that referenced this pull request Sep 25, 2018
* enable inialisation of tls client for dash comms

* remove unneccesary code in client initialisation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants