Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

Make worker handling more flexible #27

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Conversation

kaisalmen
Copy link
Collaborator

@kaisalmen kaisalmen commented Jun 14, 2023

Allow to configure a worker directly and to influence the behaviour on languageclient restart:

  • Instead of parsing only a worker configuration, you can now pass it. createLangiumGlobalConfig makes use of this for testing
  • On restartLanguageClient you can now select to not dispose a worker a provide a new one for the restart.
  • The react component required some more code to check that the previous and current config machtes

Btw, there are some formatting changes that have nothing to do with this change.

@kaisalmen kaisalmen force-pushed the wrapper-worker-enhancements branch from 79b523f to dab9d48 Compare June 15, 2023 07:59
Copy link
Member

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:octocat: Approved! Looks good.

@kaisalmen kaisalmen merged commit 09dce7c into main Jun 16, 2023
@kaisalmen kaisalmen deleted the wrapper-worker-enhancements branch June 16, 2023 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants