Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: getCustomTransformers support path string for a module #745

Merged
merged 2 commits into from
Mar 17, 2018
Merged

feat: getCustomTransformers support path string for a module #745

merged 2 commits into from
Mar 17, 2018

Conversation

vagusX
Copy link
Contributor

@vagusX vagusX commented Mar 15, 2018

With happyPackMode, the customTransformers cannot be passed as undering different process.
Workaround: pass a path string to locate a js module file which export a function return the customTransformers.
Same strategy as https://github.com/s-panferov/awesome-typescript-loader/pull/531/files
Related #739

@johnnyreilly
Copy link
Member

This is terrific! Thanks so much :-) would you be able to update the readme with example usage details please? Hopefully we can use that to create a second variant of the https://github.com/TypeStrong/ts-loader/tree/master/test/comparison-tests/customTransformer existing test

@vagusX
Copy link
Contributor Author

vagusX commented Mar 15, 2018

@johnnyreilly ok, I will update it asap.

@vagusX
Copy link
Contributor Author

vagusX commented Mar 16, 2018

@johnnyreilly I've finish those jobs. You can review it where you happen to be free

@johnnyreilly
Copy link
Member

Thanks @vagusX! Will take a look this weekend I hope

@johnnyreilly
Copy link
Member

Thanks! Will ship with the next release of ts-loader

@johnnyreilly
Copy link
Member

Released with 4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants