Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getCustomTransformers not called with happypack #739

Closed
alteredtastes opened this issue Mar 8, 2018 · 4 comments
Closed

getCustomTransformers not called with happypack #739

alteredtastes opened this issue Mar 8, 2018 · 4 comments
Labels

Comments

@alteredtastes
Copy link

Expected Behaviour

getCustomTransformers function is called during build when used with happypack

Actual Behaviour

getCustomTransformers is not called.

Steps to Reproduce the Problem

Igorbek/typescript-plugin-styled-components#6 (comment)

Location of a Minimal Repository that Demonstrates the Issue.

I believe link and discussion above provide sufficient detail.

For reference, @Igorbek points out that there is a way to do this with awesome-typescript-loader although it would be ideal for us to stick with ts-loader
s-panferov/awesome-typescript-loader@f37dacb

@alteredtastes alteredtastes changed the title getCustomTransformers not called with forked with happypack and getCustomTransformers not called with happypack Mar 8, 2018
@johnnyreilly
Copy link
Member

Thanks for the informative issue - that's super helpful!

If you'd like to have a crack at implementing a similar approach as mentioned by @Igorbek I'd be happy to take a look at your PR. Don't worry about tests failing etc - just get something in place and I'll gladly help you from there. 🌻

@vagusX
Copy link
Contributor

vagusX commented Mar 15, 2018

I've pushed a pr for this issue @johnnyreilly #745

@stale
Copy link

stale bot commented Jan 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 19, 2019
@stale
Copy link

stale bot commented Jan 26, 2019

Closing as stale. Please reopen if you'd like to work on this further.

@stale stale bot closed this as completed Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants