Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize .opus as an audio format, .h264 .hevc as video formats #43

Merged
merged 2 commits into from
May 12, 2019

Conversation

OrangeChannel
Copy link

Recognizes .opus as audio (both in-application Open dialogue and Windows Explorer file definition).
Recognizes .h264 and .hevc as a video file, not a AV container.

@FichteFoll
Copy link
Contributor

Will conflict with #36

@OrangeChannel
Copy link
Author

I'll just add yours on-top of this one with you as co-author if that's okay with you. Any other formats we should add before this gets merged?

@OrangeChannel
Copy link
Author

OrangeChannel commented Mar 12, 2019

Also, shouldn't all demux formats supported by ffmpeg whatever aegi's ffmpeg build supports be added as well? Since going forward, it seems like ffmpeg is the only AV provider.

Co-Authored-By: FichteFoll <fichtefoll2@googlemail.com>
@FichteFoll
Copy link
Contributor

I'll just add yours on-top of this one with you as co-author if that's okay with you.

Fine with me. I'm retracting #36, then.

@CoffeeFlux
Copy link
Member

I think if we're going to keep adding various formats, it's best to only register the extensions based on the build flags set for the providers. This carries with it other benefits related to configuration, but it's a bit annoying to do with the current build system. I'll merge this once I test locally and then implement flag detection in the meson branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants