Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to specify custom arguments for app restart #29

Closed
skel35 opened this issue Mar 13, 2020 · 1 comment
Closed

Add the ability to specify custom arguments for app restart #29

skel35 opened this issue Mar 13, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@skel35
Copy link

skel35 commented Mar 13, 2020

Hi @Tyrrrz! I checked out your framework and it looks very good, great job on this!

I have a tiny feature request that I might contribute myself if you're fine with it.

Currently, the app can be restarted with the same arguments that it launched with, and while it is a nice feature, that's not what I'd always want. My use case is this: the app can be run on startup in the background, using a certain cmd-line switch to make sure it starts minimized in the tray. So, if the app was started using this cmd-line switch, but the user presses "Restart & Update" in the app UI, I'd like the app to be started with the main window visible = without this cmd-line switch.

My initial idea for the API is adding a third nullable string optional argument restartArgs to UpdateManager.LaunchUpdater() method.
Let me know what you think ✌️

@Tyrrrz Tyrrrz added the enhancement New feature or request label Mar 13, 2020
@Tyrrrz
Copy link
Owner

Tyrrrz commented Mar 13, 2020

Hi @skel35, thanks!

I think that makes sense. I would suggest an overload instead of a nullable string so that the library falls back to current behavior if the parameter wasn't specified.

You're welcome to submit a PR!

@Tyrrrz Tyrrrz closed this as completed in 19060fe Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants