Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor calls to grouper_delta_user #62

Closed
astrochun opened this issue Sep 29, 2020 · 0 comments · Fixed by #61
Closed

Refactor calls to grouper_delta_user #62

astrochun opened this issue Sep 29, 2020 · 0 comments · Fixed by #61
Assignees
@astrochun
Labels
reorganization packaging and re-organization scripts Script development
Projects
ReDATA Patron Management Software
Milestone
v0.12.0

Comments

@astrochun
Copy link
Contributor

In the user_update script, multiple calls to grouper_delta_user is made and a set of sync/nosync commands are included.

Now that grouper_delta_user can receive a LogClass object, let's refactor into grouper_delta_user. This will make the code more easy to read.
@astrochun astrochun added reorganization packaging and re-organization scripts Script development labels Sep 29, 2020
@astrochun astrochun self-assigned this Sep 29, 2020
@astrochun astrochun added this to To do in ReDATA Patron Management Software via automation Sep 29, 2020
astrochun added a commit that referenced this issue Sep 30, 2020
@astrochun
grouper_delta_user: Refactor - synchronization happens with sync option
9f985b4 
#62

 - Optional mo keyword for ManualOverride object if needed
 - Implement changes in user_update script
@astrochun astrochun added this to the v0.12.0 milestone Sep 30, 2020
@astrochun astrochun moved this from To do to In progress in ReDATA Patron Management Software Sep 30, 2020
@astrochun astrochun mentioned this issue Sep 30, 2020
Merged
23 tasks
astrochun added a commit that referenced this issue Sep 30, 2020
@astrochun
Update README.md changelog for minor improvements #6 #62 #63 #64
6115f6e
ReDATA Patron Management Software automation moved this from In progress to Done Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astrochun astrochun

Labels
reorganization packaging and re-organization scripts Script development
Projects
ReDATA Patron Management Software
  
Done
Milestone
v0.12.0
Development

Successfully merging a pull request may close this issue.

release/v0.12.0 UAL-RE/ReQUIAM
1 participant
@astrochun