release/v0.12.0 #61
Merged
release/v0.12.0 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add url()
Update figshare_group()
Add verbose option in get_current_groups
Fix calls to mo.update_dataframe when root case
log revert_command if membership is empty append quota to revert_command (including root)
- Change 'org_code' section to 'google' - Update get_org_code_numbers script for section name change
PEP8 formatting #6
Add docstrings #6
Adjust log messages for bool keys
add_grouper_groups: Handle quota flag when set
Use f-strings for log filenames
Add log_stdout function
import log_stdout
import log_stdout
Update script_run, user_update, get_org_code_numbers scripts
Update user_update to pass log
Update user_update script
Update script_run
Implement in all scripts
Implement in all scripts
user_update: Add log keyword option for GrouperAPI
astrochun
commented
Sep 29, 2020
astrochun
moved this from In progress
to Needs Review / Testing
in ReDATA Patron Management Software
- Update requirements for pandas, tabulate - Implement in script_run - script_run: Strip out log info about org codes, org names
#62 - Optional mo keyword for ManualOverride object if needed - Implement changes in user_update script
astrochun
commented
Sep 30, 2020
ReDATA Patron Management Software
automation
moved this from Needs Review / Testing
to Done
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42
Fixes #52
Fixes #57
Fixes #58
Fixes #60
Fixes #62
Fixes #63
Fixes #64
The following tests are needed since there are a number of features that overlap:
script_run:pandasDataFrame for each theme/portal (see figshare_patrons.2020-09-30.log)ManualOverridefile logging is available (optional) (see figshare_patrons.2020-09-30.log)GrouperQueryfile logging is available (optional) N/Auser_update:grouper_delta_userfile logging is available (there was a minor code mistake - log written to stdout, fixed in e13b6b4)ManualOverridefile logging is available (optional) (see user_update.2020-09-30.log)LDAPConnectionfile logging is available (optional) (see user_update.2020-09-30.log)GrouperAPIfile logging is available (optional) N/A, some improvements for KeyError handling (minor)add_grouper_groups:GrouperAPIfile logging is available (optional) N/A, some improvements for KeyError handling (minor)get_org_code_numbers: (this script takes some time to run, verification in code)LDAPConnectionfile logging is available (optional)