Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSDL compiler: incorrect array serialization #64

Closed
pavel-kirienko opened this issue Oct 20, 2018 · 2 comments
Closed

DSDL compiler: incorrect array serialization #64

pavel-kirienko opened this issue Oct 20, 2018 · 2 comments
Labels

Comments

@pavel-kirienko
Copy link
Member

A bug in the updated DSDL compiler has been found:

uavcan/equipment/actuator/actuator_ArrayCommand.c: In function ‘uavcan_equipment_actuator_ArrayCommand_encode_internal’:

uavcan/equipment/actuator/actuator_ArrayCommand.c:41:93: error: subscripted value is neither array nor pointer nor vector
offset += uavcan_equipment_actuator_Command_encode_internal((void*)&source->commands[c], msg_buf, offset, 0);

commands[c] is wrong ,that is commands.data[c] is right.

@aasmune could you look into this please?

@aasmune
Copy link
Contributor

aasmune commented Oct 20, 2018

It looks like I forgot to update some parts of the template, and I didn't notice as I did not use the affected messages. I have now fixed the reported bug (and two more). I looked through the compiled DSDL code after the fixes, and it looks good to me now. However it could be that I have overlooked something, so please check again just to be sure.

@pavel-kirienko
Copy link
Member Author

Thanks @aasmune, could you send a pull request please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants