Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CLI #139

Merged
merged 29 commits into from
Dec 30, 2020
Merged

Remove CLI #139

merged 29 commits into from
Dec 30, 2020

Conversation

pavel-kirienko
Copy link
Member

Fixes #134

The new repository for the CLI is being worked on, stay tuned. This PR should be merged once it is ready.

The integration test for the demo application had to be rewritten because the old one was built on top of the CLI.

The overall directory layout has been altered: the demo script and the DSDL namespaces it depends on are now located directly under the project root at /demo/. This should make the demo more accessible.

The coverage scaffolding was changed: now we use coverage run ... directly instead of relying on sitecustomize.py. This is simpler and easier to maintain.

The integration test suite does no longer generate DSDL packages in the project root (I've been looking for an easy way to fix it for a while).

This is the last substantial changeset before the v1.1 release.

@coveralls
Copy link

coveralls commented Dec 24, 2020

Pull Request Test Coverage Report for Build 37052464

  • 341 of 350 (97.43%) changed or added relevant lines in 27 files are covered.
  • 23 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.0002%) to 95.79%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/demo/_subprocess.py 3 4 75.0%
pyuavcan/application/heartbeat_publisher.py 21 25 84.0%
tests/demo/_demo_app.py 180 184 97.83%
Files with Coverage Reduction New Missed Lines %
pyuavcan/presentation/_port/_publisher.py 1 91.27%
pyuavcan/presentation/_presentation.py 1 93.33%
pyuavcan/transport/can/media/socketcan/_socketcan.py 1 83.41%
pyuavcan/transport/can/_session/_input.py 1 98.56%
pyuavcan/presentation/_port/_client.py 2 79.4%
pyuavcan/transport/redundant/_session/_input.py 2 97.38%
pyuavcan/transport/udp/_session/_input.py 2 83.78%
pyuavcan/presentation/_port/_base.py 3 90.91%
pyuavcan/application/heartbeat_publisher.py 4 88.89%
pyuavcan/presentation/_port/_subscriber.py 6 80.6%
Totals Coverage Status
Change from base Build 36965372: 0.0002%
Covered Lines: 11055
Relevant Lines: 11407

💛 - Coveralls

…imeout values may cause issues depending on the performance of the garbage collector
…rrors as early as possible. The old behavior was a legacy from the time when it was possible to change the local node-ID at runtime; it no longer makes sense.
…ere the transport is anonymous and the output session cannot be created
@pavel-kirienko pavel-kirienko force-pushed the cli-removal branch 3 times, most recently from b3d905f to 6c0ec7e Compare December 29, 2020 15:04
@pavel-kirienko
Copy link
Member Author

Done, the new tool is available for use. Read the announcement here: https://forum.uavcan.org/t/yakut-the-new-name-for-pyuavcan-cli-tool/1049

@pavel-kirienko pavel-kirienko marked this pull request as ready for review December 30, 2020 21:34
@pavel-kirienko pavel-kirienko enabled auto-merge (squash) December 30, 2020 21:36
@pavel-kirienko pavel-kirienko merged commit a4d9fa9 into master Dec 30, 2020
@pavel-kirienko pavel-kirienko deleted the cli-removal branch December 30, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract the CLI tool into a separate package/repository
2 participants