Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tune Pass Speed with Pass Distance #2918
Tune Pass Speed with Pass Distance #2918
Changes from 21 commits
021d61d
1657a93
3f9dc79
1c08c7d
4f21d2e
b59eb7d
ae4adab
f40af89
d482e6b
6f34861
9010163
84c3a4f
ebbeb5e
c5e34df
b34e972
5021ade
a9725ec
fd34328
023d854
c72e46c
044e7a2
a8bd1c1
babac45
ff36d13
5cc2e7f
4a15972
0ca8c80
3327f89
5893fe8
ff478bf
80e07c2
e3dfe1d
d97fe64
00e1e55
b473d69
d02f173
0ccf164
ad6ff93
45771d3
37d3785
629a936
3844cb2
77d2354
6954b80
62dda73
7df5317
03d8344
fbb2563
ee2b01b
b14e6c6
6e99bc1
de6aaa2
0c3c936
423c981
a1f5fcc
67d5c57
c2c1a22
7b127db
55fb728
dba41a4
7cffa2c
de1b49a
7ad435b
ea5d942
716e001
38f0ee6
17c02ae
c5ffe99
88ce00f
283a02a
608f743
482a18d
5862749
bdcccc1
96672f0
62fa115
0e35e7e
732d579
94fd82b
29144df
43ee59a
e26305a
f84b0bd
b4354db
4b68c6d
e009c65
8ec3a81
186c564
9b6a39d
2a38293
2ea63fa
0032638
f3d59aa
9357893
3acee00
6f7cffd
34d9e5b
decf751
e65f394
904d9a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like it should be in the passing dynamic parameters proto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these tests ready at their current state? Tried running them locally and some of them didn't look correct. Also, we should be careful with the tests so theyre not too fragile, E.g. the accuracy of our pass direction may not be perfect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also why is the test under the
pass_defender
directory?it's probably better under
kick_tactic
or generally undertactic
orplay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return description missing