Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Fix file structure to make more sense #38

Closed
robbietuk opened this issue Jul 25, 2020 · 4 comments
Closed

Suggestion: Fix file structure to make more sense #38

robbietuk opened this issue Jul 25, 2020 · 4 comments
Labels
Suggestion A suggestion on how to improve the project

Comments

@robbietuk
Copy link
Collaborator

Currently the file structure does not make too much sense. Everything is currently run from STIR-GATE-Connection/VoxelisedSimulation/ and the main scripts are there. The project "Home" directory contains ExampleScanners/, ExamplePhantoms/ and VoxelisedSimulation/.

I propose that the content of VoxelisedSimulation/ be moved into the main directory, which would continue to contain ExampleScanners/ and ExamplePhantoms/ .

Currently no rush for this. It would break a lot of backwards compatibility. Maybe aim for v2.0?

@KrisThielemans
Copy link
Collaborator

I don't know. I don't mind a clean project directory with very little in there...

Possibly the name VoxelisedSimulation doesn't quite cover it anymore.

I'd consider more moving remain scripts in images elsewhere. It's very nonintuitive that they are there.

I'd also consider moving https://github.com/UCL/STIR-GATE-Connection/blob/master/VoxelisedSimulation/Output/Templates/lm_to_projdata_template.par elsewhere, which would then happily allow you to get rid of Output (Obviously you'd have to create those directories then in the script, but at some point you want to allow the output to be in other places, so then you'd have to create them anyway)

I wouldn't worry about backwards compatibility just yet. You haven't release v1.0 yet anyway 😄 . About time that you do though.

@robbietuk
Copy link
Collaborator Author

I don't know. I don't mind a clean project directory with very little in there...
Possibly the name VoxelisedSimulation doesn't quite cover it anymore.

Prehaps you're right, the name of the directory bugs me... and the fact ExamplePhantoms/ and ExampleScanners/ are in there. I will move them.

The templates and additional scripts will also be moved so Output/ doesn't contain anything. See #37

@robbietuk robbietuk added the Suggestion A suggestion on how to improve the project label Jul 27, 2020
@robbietuk
Copy link
Collaborator Author

This was partly addressed by #41

@robbietuk
Copy link
Collaborator Author

My above comment was incorrect. This is all addressed by #41 except for the renamed of VoxelisedSimulation/, which is fine for now. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion A suggestion on how to improve the project
Projects
None yet
Development

No branches or pull requests

2 participants