Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom.cxx and origin #254

Open
KrisThielemans opened this issue Sep 29, 2018 · 1 comment
Open

zoom.cxx and origin #254

KrisThielemans opened this issue Sep 29, 2018 · 1 comment
Milestone

Comments

@KrisThielemans
Copy link
Collaborator

KrisThielemans commented Sep 29, 2018

When using even-sized images, there's confusion about how zoom_image works (when specifying zoom factors, as opposed to an image), as it attempts to zoom around the "centre" of the image. This is somewhat described in the FAQ.

this won't be possible anymore once we support non-standard bed positions etc, see #223.

Note: changing this will break backwards compatibility.

@KrisThielemans KrisThielemans added this to the v4.0 milestone Sep 29, 2018
@KrisThielemans KrisThielemans modified the milestones: v4.0, v4.1 Oct 14, 2019
@KrisThielemans KrisThielemans modified the milestones: v4.1, v6.0 May 23, 2020
@ashgillman
Copy link
Collaborator

I think #618 simplifies this a lot. Now we can say that zoom_images merely preserves the location of features with respect to the global physical origin (centre of the first ring), unless an offset is supplied, which acts to translate the image physically.

Regarding "Combining images and projection data" - the gantry_coord system used by ProjData defines (0, 0, 0) as the centre of the gantry, and the physical_coord system used by Densities define (0, 0, 0) as the centre of the first ring (looking into the scanner from the bed). ProjDataInfo is the only place that has the functions responsible for moving between these systems.

@KrisThielemans KrisThielemans modified the milestones: v6.0, v7.0 Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants