-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/consolidating edit menu #442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few bugs here:
- I couldn't get Delete to work with or without an editing lock in place
- Warnings don't show up for make anonymous/unlinked or duplicate
- If no lock is in place, when you click make anonymous/unlinked you get a message saying you can't because there's no lock
You're not going to be happy with me but I think it might be better if we just have the consolidated 'Actions' menu in edit mode, and keep the original 'Edit' menu for when there isn't a lock.
I don't think we have any duplication warnings set up |
To do: |
need to update so testimonia have the option for duplication and update unlinked with option to convert to testimonium |
This is currently disabled but will be enabled in a later PR which addresses this functionality
closes #434 and #447
The
Edit
menu has been rejigged to better display options and complete actions without having to require an editing lock. This helps bring more consistency and reduces the code volume.Below are screengrabs:
(unlinked) fragment without editing lock:
when editing:
testimonia, works and antiquarians when editing:
anonymous without editing lock: