Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/consolidating edit menu #442

Merged
merged 13 commits into from
Jun 18, 2024
Merged

Conversation

acholyn
Copy link
Collaborator

@acholyn acholyn commented Mar 14, 2024

closes #434 and #447

The Edit menu has been rejigged to better display options and complete actions without having to require an editing lock. This helps bring more consistency and reduces the code volume.

  • Deletion, conversion and duplication are available where relevant without needing a lock and are available when there is a lock
  • locking editing is available from the same menu as a dropdown

Below are screengrabs:

(unlinked) fragment without editing lock:
image

when editing:
image

testimonia, works and antiquarians when editing:
image

anonymous without editing lock:
image

@acholyn acholyn marked this pull request as ready for review March 14, 2024 16:33
@acholyn acholyn requested a review from tcouch March 14, 2024 16:33
Copy link
Collaborator

@tcouch tcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few bugs here:

  • I couldn't get Delete to work with or without an editing lock in place
  • Warnings don't show up for make anonymous/unlinked or duplicate
  • If no lock is in place, when you click make anonymous/unlinked you get a message saying you can't because there's no lock

You're not going to be happy with me but I think it might be better if we just have the consolidated 'Actions' menu in edit mode, and keep the original 'Edit' menu for when there isn't a lock.

@acholyn
Copy link
Collaborator Author

acholyn commented Mar 20, 2024

I don't think we have any duplication warnings set up
Shall the menu be "edit" as before (when no lock) or still actions > edit

@acholyn
Copy link
Collaborator Author

acholyn commented Mar 21, 2024

To do:
change it back so that the options are only available when there's a lock

@acholyn acholyn marked this pull request as draft March 27, 2024 10:35
@acholyn acholyn changed the base branch from development to feature/duplicate-fragments April 26, 2024 17:02
@acholyn acholyn marked this pull request as ready for review April 26, 2024 17:02
Base automatically changed from feature/duplicate-fragments to development May 2, 2024 07:55
@acholyn acholyn requested a review from tcouch May 2, 2024 07:56
@acholyn
Copy link
Collaborator Author

acholyn commented May 2, 2024

need to update so testimonia have the option for duplication and update unlinked with option to convert to testimonium

@acholyn acholyn marked this pull request as draft May 2, 2024 12:20
This is currently disabled but will be enabled in a later PR which addresses this functionality
@acholyn acholyn marked this pull request as ready for review May 7, 2024 12:27
@acholyn acholyn merged commit 43dd082 into development Jun 18, 2024
5 checks passed
@acholyn acholyn deleted the feature/consolidating-edit-menu branch June 18, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consolidate action options into edit dropdown
2 participants