Feature/duplicating testimonia #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently disabled but will be enabled in a later PR which addresses this functionality
tcouch
requested changes
Jun 14, 2024
src/rard/research/migrations/0071_add_duplicates_field_squashed.py
Outdated
Show resolved
Hide resolved
| else: | ||
| # otherwise delete it from the anonfrag being converted | ||
| source.duplicate_afs.remove(d) | ||
| def transfer_duplicates(source, destination): |
There was a problem hiding this comment.
Updated in recent commit to ensure destination is added as duplicate of the source's duplicate as well as the reverse relationship being created.
| blank=True, | ||
| related_name="%(class)s_duplicate_ts", | ||
| ) | ||
|
|
||
| @property | ||
| def duplicates_list(self): | ||
| duplicates = list(self.duplicate_frags.all()) |
There was a problem hiding this comment.
I've simplified this in the latest commit: as long as we make sure duplicate relationships are always bi-directional, we shouldn't have to look at the reverse relationships.
think it's in #442 (re button) |
tcouch
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #450