Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing delete not working in new menu format #464

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

acholyn
Copy link
Collaborator

@acholyn acholyn commented Jun 18, 2024

closes #434

#442 automatically merged when #456 did so have done this fix separately

The delete form wasn't rendering because of the nesting within the bigger form so I've split the menu into 2 versions, one for when it's locked, and one for when it's unlocked, with the relevant forms

@acholyn acholyn requested a review from tcouch June 18, 2024 09:52
Copy link
Collaborator

@tcouch tcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@acholyn acholyn merged commit c11a8df into development Jun 18, 2024
5 checks passed
@acholyn acholyn deleted the fix/new-menu branch June 18, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consolidate action options into edit dropdown
2 participants