-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connector #26
Add connector #26
Conversation
This is a good start I think -- but I think it could be improved a little bit.
|
Thinking about it a bit more, I'm starting to lean towards destroying the Basically, you shouldn't have the |
@bsmithgall That makes a lot of sense. I definitely kept getting the vibe that it wasn't making things simpler, but couldn't think of a good alternative. I'll work on implementing what you described and I'll let you know when I make any significant commits if you'd like to take a look. |
👍 If you want you could also take a crack at #15 and I could do some work on this, or I could take that from you as I think those are the last two big ones. |
@bsmithgall That works for me. I already stared a bit on #15, so I'll finish that up. |
@bsmithgall Sounds good! I'm free until 4, so whenever works for you will probably work for me. |
Because this branch has failing tests & merge conflicts, I'm going to close it and open a different PR if that's alright. |
👍 Looks good. Are you waiting for the other two know connectors to be implemented before you make the pull request? |
Yeah or at least one
|
Sounds good. Do you plan on/already started doing so or mind if I take a swing at it? |
Go for it. I'll ping you when I'm home and we can pair on the rest.
|
@bsmithgall Forgot to remake this PR. Please feel free to take a look whenever you have the time. Note: there are no tests written yet - I plan to do that Monday - but I figured at least this way you can take look.