Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpolatestoptimes() function continues to interpolate past known time values #6

Closed
sablanchard opened this issue Mar 11, 2017 · 2 comments
Assignees

Comments

@sablanchard
Copy link
Contributor

The interpolatestoptimes() function continues to interpolate past known time values using the last value in the series. This results downstream in a travel time value of 0 between those stops. These consecutive nans at the end of a series should be removed and not interpolated.

incorrect:
input = nan, 2, 3, nan, 5, 6, nan, nan
output = nan, 2, 3, 4, 5, 6, 6, 6

correct:
input = nan, 2, 3, nan, 5, 6, nan, nan
output = nan, 2, 3, 4, 5, 6 (drop the last consecutive records with nan from result)

@sablanchard
Copy link
Contributor Author

This was not an issue before this commit: 4c1a296 so it was introduced as part of the pivot method.

@sablanchard
Copy link
Contributor Author

Fixed with #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants