Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N-06 [Oval] State Variable Visibility Not Explicitly Declared #21

Merged
merged 3 commits into from
Jun 19, 2024
Merged

N-06 [Oval] State Variable Visibility Not Explicitly Declared #21

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9977256
fix[oval-audit-n-06]: State Variable Visibility Not Explicitly Declared
md0x Jun 17, 2024
11a13ac
Merge branch 'master' into pablo/uma-2653-n-06-oval-state-variable-vi…
md0x Jun 18, 2024
9a02a41
feat: pyth uppercase
md0x Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/factories/StandardCoinbaseFactory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ contract OvalCoinbase is MutableUnlockersController, CoinbaseSourceAdapter, Chai
* mutability choices are desired.
*/
contract StandardCoinbaseFactory is Ownable, BaseFactory {
IAggregatorV3SourceCoinbase immutable SOURCE;
IAggregatorV3SourceCoinbase public immutable SOURCE;

constructor(IAggregatorV3SourceCoinbase _source, uint256 _maxTraversal, address[] memory _defaultUnlockers)
BaseFactory(_maxTraversal, _defaultUnlockers)
Expand Down
2 changes: 1 addition & 1 deletion src/factories/StandardPythFactory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ contract OvalPyth is MutableUnlockersController, PythSourceAdapter, ChainlinkDes
* needed if different mutability or interface choices are desired.
*/
contract StandardPythFactory is Ownable, BaseFactory {
IPyth immutable pyth;
IPyth public immutable pyth;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some inconsistency here: in the src/factories/StandardCoinbaseFactory.sol the public immutable variable is all caps. here, its not. This should be standardized. same goes for the src/oracles/CoinbaseOracle.sol


constructor(IPyth _pyth, uint256 _maxTraversal, address[] memory _defaultUnlockers)
BaseFactory(_maxTraversal, _defaultUnlockers)
Expand Down
2 changes: 1 addition & 1 deletion src/oracles/CoinbaseOracle.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {IAggregatorV3SourceCoinbase} from "../interfaces/coinbase/IAggregatorV3S
* @notice A smart contract that serves as an oracle for price data reported by a designated reporter.
*/
contract CoinbaseOracle is IAggregatorV3SourceCoinbase {
address immutable reporter;
address public immutable reporter;

uint8 public immutable decimals;

Expand Down
Loading