Implement state class

[loganchen39]

@travissluka I've finished the class State and passed all the tests. please check and merge my branch develop_chen to branch develop. As for the next step,

1. Once it's been merged, and since the JEDI github location has been changed, I plan to download the OISSTv3 develop branch and re-compile it from the beginning (since there has been a lot of changes).

2. This is from your comments, "focus on state for now, I think what we should do for increment is to actually move the common methods of state and increment, as well as the the atlasFieldSet variable, into a common Fields base class. You can either do this now, or wait until you have most of State implemented. That way we wont have as much duplicate code between State and Increment". I know that classes of State and Increment have similar content, and it makes sense to me to combine them in some way, but it is related to the STRUCTURE of the program, shall we follow what JEDI's structure? What is your plan and suggestion?

closes #7

[travissluka]

You never merged in the latest develop branch, you need to do that and resolve the conflicts first

[travissluka]

Thanks @loganchen39 , sorry that a lot of this seemed like annoying bookkeeping! (it should get more interesting with the subsequent implementation steps). I added some quick comments, but I'll take a closer look once you merge this with the latest develop. Since a lot has changed in oops (including more tests being added) it's possible that your tests will no longer pass after pulling the latest versions of the jedi repositories.

[travissluka]

I'm not entirely sure, but I think TravisCI is refusing to run the tests until the merge conflicts are resolved

[travissluka]

@loganchen39 I fixed a data/ Data/ mixup, the TravisCI tests should work now. Once they do I'll approve and merge.

Now that the code base is starting to get bigger, and we might have more things going on simultaneously, I'm going to start adding "to-do" items as issues in github. I can help out from time to time on some of these, so to prevent overlap assign yourself on an issue before starting work so we know who is doing what (I already assigned you for the next step of implementing Increment). WHen you issue a PR, if you put "closes #<issue_number>" the associated issue will be closed when the PR is merged.

[loganchen39]

@travissluka Thanks for your suggestions. I'm actually quite new to this git/github stuff. Previously I learned that I should never code on develop branch, but only on my own branch develop_chen. If there's any change on develop branch and I have "git pull" to merge to my local develop branch, what are the commands to merge branch develop to develop_chen?

Now that my current version of branch develop_chen passed all the test, I'd like merge it to develop branch on github, and then I'll re-download and re-compile all the code since there's been a lot changes, and then I'll work on with your suggestions above, (e.g. change name sst, delete std::cout etc.).

[travissluka]

👍 TravisCI was being slow yesterday for some weird reason, the tests were just sitting in the queue for hours... weird.

[travissluka]

:+1

@travissluka Thanks for your suggestions. I'm actually quite new to this git/github stuff. Previously I learned that I should never code on develop branch, but only on my own branch develop_chen. If there's any change on develop branch and I have "git pull" to merge to my local develop branch, what are the commands to merge branch develop to develop_chen?

Now that my current version of branch develop_chen passed all the test, I'd like merge it to develop branch on github, and then I'll re-download and re-compile all the code since there's been a lot changes, and then I'll work on with your suggestions above, (e.g. change name sst, delete std::cout etc.).

One thing I would recommend is that you use branches with meaningful names. It's best practice to create a new branch, from develop, for each new feature/bugfix that is being added. Reusing the same branch name can cause small issues with other people pulling your branch.

when you're going back to develop, just run

git checkout develop
git pull

to get the latest develop branch, and make sure to run make update within the build directory to have ecbuild pull the latest versions of the JEDI repositories.

when you're working on your work branch, the easiest way to make sure you have the latest develop merged in is run

git fetch --all
git merge origin/develop

with these commands you don't have to switch branches before merging Alternatively you could merge in the latest develop using

git checkout develop
git pull
git checkout <your branch>
git merge develop

.... but that's more to have to do.

[loganchen39]

@travissluka Thanks a lot, will follow these suggestions.