tagged Release/2021.5.0 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove makeobs.x, no longer needed * remove Model class, no longer needed (#1)
* ctest passed for Geometry class * Modified test CMakeLists.txt * Travis's suggested changes completed by Ligang * Travis's suggested changes completed by Ligang
* Temporary implememting class State for Travis to check. * Updated State.cc * Updating class State * Updating class State. * Updating class State. * Updating class State. * Finished class State, passed all test. * Passed all test for class State. * fix binary path Co-authored-by: Travis Sluka <travissluka@gmail.com>
* Finished class Increment. * Finished class increment. * Updated increment.yml for class increment. * Updated for class Increment.
Merged.
* rename to umdsst * switch to public jedi repo locations * fix travisci
* start GetValues * add level(1) to fields * getvalues working?
* Implemented class LinearGetValues, passed all tests. * minor change of a comment.
* add hofx_nomodel test * remove use of external OOPS_TRAPFPE env var, deal with that later
* Implementing dirac.x. * Finished feature dirac.x. * Finishing feature/dirac.x. Co-authored-by: Travis Sluka <travissluka@gmail.com>
* Fixed conversion between Celsius and Kelvin. * Finished bugfix/C_K_conversion.
* Implementing staticbinit.x * Finished feature/staticbinit.x * Finished feature/staticbinit.x 2nd Time.
* Implementing feature/var.x. * Implementing feature/var.x. * Implementing var.x * Finished feature/var.x. * Finished feature/var.x.
* added landmask.nc * Finished feature/addMaskField. * Finished feature/addMaskField. * Finished feature/addMaskField. * Remove hardcoded 180 and 360.
* Finished feature/useLandmask. * Finished feature/useLandmask. * Finished feature/useLandmask.
* clean old bump files on test run * manually specify correlation lengths * fix coding norms * fix dependencies of errorcovariance test
* Finished AddQC, Solved problems with passing vector of pointers of FieldImpl from C to Fortran. * Finishing feature/addQC.
* Test improved landmask. * Finished feature/betterLandmask. * Finished feature/betterLandmask.
* convert corr length from gaussian to GC * add "default" var change * update reference answers
Approved.
* invert lat on netcdf I/O * landmask is explicitly applied to background * flood the test background file * fix landmask/grid in yamls * update reference answers
* fields working for any number of fields * implement Model2GeoVaLs * remove ggmask from Geometry * cleanup
* rossby radius based corr loc, using dummy RR values * kd interpolation in geometry * using rossby radius in covariance * fix tests and coding norms * document interptogeom * add .dat to lfs * fix compile error
* support for module with new ecbuild * use public atlas/fckit
…#77) * Added some 0.25x0.25 files. * Added new initial background for 20120101. * Updated for some initial background of 0.25x025 grid. * Updated initial background of 0.25x0.25 grid. * Updated yml files with correct renamed file names. * Updated to have correct file names.
|
@travissluka Ok, I'll try to test on Cheyenne. |
loganchen39
approved these changes
May 21, 2021
There was a problem hiding this comment.
Approved, it passed test on Cheyenne, without building atlas and fckit. The atlas module on Cheyenne requires the latest eckit/ecmwf-1.16.0, so in order to use which we need to "module load jedi/gnu-openmpi/ecbuild35" instead of using the previously working version of jedi/gnu-openmpi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@loganchen39 I would like to create our first "release" so that we have a stable version of the code that we can always go back to as we do our experiments.
I realize the "files changed" below looks overwhelming, but that is because this is a PR going into he
masterbranch, not thedevelopwe've normally been working in. You can see here: https://github.com/UMD-AOSC/UMD-SST/compare/release/2021.5.0 that the only change fromdevelopis that I have specified an exact git hash version for each of the jedi repositories instead of the normaldevelop. This way, this release is guaranteed to always pull the same versions and not be affected by changes to JEDIdevelopbranches.Whenever you get a chance, could verify that this works on Cheyenne before it is approved and merged? (I don't have Cheyenne access)